Updated the primitive docs for bool #31843
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| /// # Examples | ||
| /// | ||
| /// [`assert!`](std/macro.assert!.html), being an important macro in testing, checks | ||
| /// whether an expression returns `bool`. |
There was a problem hiding this comment.
Maybe say "checks whether an expression results in true" here instead.
There was a problem hiding this comment.
You're right :)
wafflespeanut
force-pushed
the
bool_docs
branch
from
35754cd
to
3fe7e5f
Compare
| @@ -10,8 +10,46 @@ | |||
|
|
|||
| #[doc(primitive = "bool")] | |||
| // | |||
| /// The boolean type. | |||
| /// The boolean type represents a value, which could only be either `true` or `false`. | |||
There was a problem hiding this comment.
I would like to move this addition into the body, rather than being the main comment. Symmetry: http://doc.rust-lang.org/std/#primitives
|
A welcome improvement! Some more nits from me, now that I've had some time to digest :) |
wafflespeanut
force-pushed
the
bool_docs
branch
from
3fe7e5f
to
f810425
Compare
wafflespeanut
force-pushed
the
bool_docs
branch
from
f810425
to
eb97c26
Compare
|
@bors: r+ rollup Let's |
|
📌 Commit eb97c26 has been approved by |
|
Thanks! :) |
fixes #29332
r? @steveklabnik