Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc examples on pointer types #32581

Merged
merged 1 commit into from
Mar 30, 2016
Merged

Conversation

GuillaumeGomez
Copy link
Member

@@ -212,6 +212,14 @@ pub unsafe fn write_volatile<T>(dst: *mut T, src: T) {
#[lang = "const_ptr"]
impl<T: ?Sized> *const T {
/// Returns true if the pointer is null.
///
/// Example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be the # Examples headers like the rest of the docs?

@steveklabnik
Copy link
Member

Just some formatting things, I only left one comment, but it applies to all of them. Happy with this otherwise!

@GuillaumeGomez
Copy link
Member Author

Updated.

@steveklabnik
Copy link
Member

It's Examples with an s. Even though there's only one, same deal: consistency everywhere.

After that, this is finally good to go 😄

@GuillaumeGomez
Copy link
Member Author

And re-updated (I added ignore on as_ref examples to avoid failure since I think it's better to avoid using feature in examples).

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 29, 2016

📌 Commit 5b08ab5 has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Mar 30, 2016

⌛ Testing commit 5b08ab5 with merge 70b8b94...

bors added a commit that referenced this pull request Mar 30, 2016
@bors bors merged commit 5b08ab5 into rust-lang:master Mar 30, 2016
@GuillaumeGomez GuillaumeGomez deleted the patch-3 branch March 30, 2016 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants