Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librustc_back: fix incorrect comment about RUST_TARGET_PATH #32856

Merged
merged 1 commit into from
Apr 15, 2016

Conversation

cardoe
Copy link
Contributor

@cardoe cardoe commented Apr 9, 2016

The path /etc/rustc/ is not the default last entry in
RUST_TARGET_PATH. This was in RFC131 but was never implemented in rustc
so it was removed as part of #31117 and rust-lang/rfcs#1473.

Signed-off-by: Doug Goldstein cardoe@cardoe.com

The path `/etc/rustc/` is not the default last entry in
RUST_TARGET_PATH. This was in RFC131 but was never implemented in rustc
so it was removed as part of rust-lang#31117 and rust-lang/rfcs#1473.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+ a4579c5

@cardoe
Copy link
Contributor Author

cardoe commented Apr 11, 2016

Do I need to rebase this change or anything? It should cleanly rebase.

@alexcrichton
Copy link
Member

Nah so long as this cleanly merges bors will get around to it eventually. You can see the queue here as well

@alexcrichton
Copy link
Member

@bors: rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 14, 2016
…hton

librustc_back: fix incorrect comment about RUST_TARGET_PATH

The path `/etc/rustc/` is not the default last entry in
RUST_TARGET_PATH. This was in RFC131 but was never implemented in rustc
so it was removed as part of rust-lang#31117 and rust-lang/rfcs#1473.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
@bors
Copy link
Contributor

bors commented Apr 14, 2016

⌛ Testing commit a4579c5 with merge a41b4e5...

@bors
Copy link
Contributor

bors commented Apr 14, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Apr 14, 2016 at 12:38 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-msvc-64-opt-rustbuild
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/705


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#32856 (comment)

bors added a commit that referenced this pull request Apr 14, 2016
@bors bors merged commit a4579c5 into rust-lang:master Apr 15, 2016
@cardoe cardoe deleted the target-spec-path branch July 21, 2016 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants