Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more aliases for Unicode confusable chars #33128

Merged
merged 4 commits into from
May 5, 2016

Conversation

xen0n
Copy link
Contributor

@xen0n xen0n commented Apr 21, 2016

Building upon #29837, this PR:

  • added aliases for space characters,
  • distinguished square brackets from parens, and
  • added common CJK punctuation characters as aliases.

This will especially help CJK users who may have forgotten to switch off IME when coding.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@xen0n xen0n changed the title Add more confusing unicode character aliases Add more aliases for Unicode confusable chars Apr 21, 2016
@nagisa
Copy link
Member

nagisa commented May 3, 2016

I guess I’ll r+ this.

@bors r+


Sorry for the delay!

@bors
Copy link
Contributor

bors commented May 3, 2016

📌 Commit 496081c has been approved by nagisa

@bors
Copy link
Contributor

bors commented May 3, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented May 3, 2016

📌 Commit 496081c has been approved by nagisa

@bors
Copy link
Contributor

bors commented May 3, 2016

⌛ Testing commit 496081c with merge ff9cf47...

bors added a commit that referenced this pull request May 3, 2016
Add more aliases for Unicode confusable chars

Building upon #29837, this PR:

* added aliases for space characters,
* distinguished square brackets from parens, and
* added common CJK punctuation characters as aliases.

This will especially help CJK users who may have forgotten to switch off IME when coding.
@bors
Copy link
Contributor

bors commented May 3, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@nagisa
Copy link
Member

nagisa commented May 3, 2016

@bors retry

@alexcrichton
Copy link
Member

Spurious because of #33391

@alexcrichton
Copy link
Member

@bors: retry force clean

1 similar comment
@alexcrichton
Copy link
Member

@bors: retry force clean

@bors
Copy link
Contributor

bors commented May 5, 2016

⌛ Testing commit 496081c with merge 413bafd...

bors added a commit that referenced this pull request May 5, 2016
Add more aliases for Unicode confusable chars

Building upon #29837, this PR:

* added aliases for space characters,
* distinguished square brackets from parens, and
* added common CJK punctuation characters as aliases.

This will especially help CJK users who may have forgotten to switch off IME when coding.
@bors bors merged commit 496081c into rust-lang:master May 5, 2016
@xen0n xen0n deleted the more-confusing-unicode-chars branch May 5, 2016 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants