save-analysis: JSON mk2 #33568
Merged
save-analysis: JSON mk2 #33568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| error!("Error writing output"); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| macro_rules! impl_fn { | ||
| ($fn_name: ident, $data_type: ident) => { | ||
| ($fn_name: ident, $data_type: ident, $bin: ident) => { |
There was a problem hiding this comment.
What does the name $bin mean here? Is this $bin in the sense of "container" (i.e. the container that is receiving the values being converted from the input data)?
(Usually when a see the word "bin", my first thought is that it is short for "executable binary", like /usr/bin, so that's why I ask.)
There was a problem hiding this comment.
Yeah, bin as in container, I couldn't think of a better name, but I wasn't very happy with it.
|
@nrc r=me; up to you whether to rename that |
|
@bors: r=pnkfelix (changed bin -> bucket) |
|
📌 Commit 6d6986b has been approved by |
bors
added a commit
that referenced
this pull request
May 14, 2016
save-analysis: JSON mk2 cc @aochagavia r? @pnkfelix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @aochagavia
r? @pnkfelix