Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable debuginfo tests for a given blacklist of LLDB versions #34499

Merged
merged 1 commit into from
Jun 30, 2016

Conversation

michaelwoerister
Copy link
Member

@michaelwoerister michaelwoerister commented Jun 27, 2016

Anyone having trouble with most LLDB tests failing on OSX, please report your LLDB version here so I can add it to the blacklist.

Blacklisted versions so far:

  • lldb-350.*

cc @rust-lang/tools
cc @tedhorst @indutny @jonathandturner (people from the original bug report)

Fixes #32520.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@indutny
Copy link
Contributor

indutny commented Jun 27, 2016

A question, are you sure that it can't be fixed by building against lldb 380 headers? That's what I did for my lldb plugin.

@alexcrichton
Copy link
Member

Thanks @michaelwoerister! I wonder if this logic could perhaps be moved to compiletest to ensure that this is fixed in rustbuild as well?

@michaelwoerister
Copy link
Member Author

@indutny I don't think there's a way to fix these problems the way you suggest (we are not building an LLDB plugin, just using LLDB via Python).

@michaelwoerister
Copy link
Member Author

@alexcrichton Sure, I'll look into it.

@michaelwoerister michaelwoerister force-pushed the lldb-blacklist branch 4 times, most recently from 37270f3 to 0e94481 Compare June 27, 2016 18:36
@michaelwoerister
Copy link
Member Author

@alexcrichton I've moved the check to compiletest. The version comparison is less fine-grained there but I think that's OK.

@alexcrichton
Copy link
Member

@bors: r+ f41de0f

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 29, 2016
…alexcrichton

Disable debuginfo tests for a given blacklist of LLDB versions

Anyone having trouble with most LLDB tests failing on OSX, please report your LLDB version here so I can add it to the blacklist.

Blacklisted versions so far:
* lldb-350.*

cc @rust-lang/tools
cc @tedhorst @indutny @jonathandturner (people from the original bug report)

Fixes rust-lang#32520.
bors added a commit that referenced this pull request Jun 30, 2016
Rollup of 11 pull requests

- Successful merges: #34355, #34446, #34459, #34460, #34467, #34495, #34497, #34499, #34513, #34536, #34542
- Failed merges:
@bors bors merged commit f41de0f into rust-lang:master Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants