Build: Shows total time taken to build the compiler #34614
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -390,5 +398,9 @@ def main(): | |||
| env["BOOTSTRAP_PARENT_ID"] = str(os.getpid()) | |||
| rb.run(args, env) | |||
|
|
|||
| end_time = time() | |||
|
|
|||
| print("Build completed in %s" % format_build_time(end_time - start_time)) | |||
There was a problem hiding this comment.
Nit: No need for a format string here, just use print("Build completed in in" + format_build_time(end_time - start_time))
Aside: Why doesn't this script have from __future__ import print_function? It would make printing simpler since one wouldn't have to perform manual string interpolation/concatenation everywhere).
There was a problem hiding this comment.
I like using formatting in place of concatenation. Seems cleaner imo 😊
There was a problem hiding this comment.
Yeah, concatenation is not ideal, IMHO the best option is simply print("...", timedelta) but that requires adding the __future__ import and that's probably out of scope. Perhaps I'll prepare a PR for that, since it seems #33036 was abandoned.
Build: Shows total time taken to build the compiler Fixes #34600 Prints the total time taken to build rustc by executing `src/bootstrap/bootstrap.py`; also includes time taken to download `stage0` compiler and deps. r? @alexcrichton
Fixes #34600
Prints the total time taken to build rustc by executing
src/bootstrap/bootstrap.py; also includes time taken to downloadstage0compiler and deps.r? @alexcrichton