Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.11 changelog #35736

Merged
merged 1 commit into from
Aug 18, 2016
Merged

1.11 changelog #35736

merged 1 commit into from
Aug 18, 2016

Conversation

brson
Copy link
Contributor

@brson brson commented Aug 16, 2016

Rendered

r? @steveklabnik

It's too late to get this into the actual release, but still needs to be backported to 1.12 beta.

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 16, 2016
@durka
Copy link
Contributor

durka commented Aug 17, 2016

#34908 is left out.

(https://github.com/rust-lang/rust/pull/34067)
* [`assert_eq!` accepts a custom error message, like `assert!` does]
(https://github.com/rust-lang/rust/pull/33976)
* [The main thread is now called "main" instead of "<main>"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"

" seems not rendered properly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I bet this looks like HTML, needs backticks.

@steveklabnik
Copy link
Member

LGTM except that one nit,

@brson
Copy link
Contributor Author

brson commented Aug 17, 2016

@durka It looks to me like that PR is not in the 1.11 commit range.

@brson
Copy link
Contributor Author

brson commented Aug 17, 2016

Updated.

@durka
Copy link
Contributor

durka commented Aug 17, 2016

Oh, my bad. I was looking at the merged date but I guess I got confused.

On Aug 17, 2016 18:16, "Brian Anderson" notifications@github.com wrote:

Updated.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35736 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC3nzs_4s9LfZni6K4WyzHsYSgSb6lCks5qg4gngaJpZM4Jl8Sg
.

@steveklabnik
Copy link
Member

@bors: r+ p=2

@bors
Copy link
Contributor

bors commented Aug 17, 2016

📌 Commit 9863afe has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Aug 17, 2016

⌛ Testing commit 9863afe with merge aef6971...

bors added a commit that referenced this pull request Aug 17, 2016
1.11 changelog

[Rendered](https://github.com/brson/rust/blob/9863afe029092d421c9a3daafd6b7a718d53f1cf/RELEASES.md)

r? @steveklabnik

It's too late to get this into the actual release, but still needs to be backported to 1.12 beta.
@bors bors merged commit 9863afe into rust-lang:master Aug 18, 2016
@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 18, 2016
@nikomatsakis
Copy link
Contributor

Despite the high risk, @rust-lang/compiler decided this is an acceptable backport.

@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants