Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error format for E0232 #35812

Merged
merged 1 commit into from
Aug 20, 2016
Merged

Update error format for E0232 #35812

merged 1 commit into from
Aug 20, 2016

Conversation

mlayne
Copy link
Contributor

@mlayne mlayne commented Aug 18, 2016

Fixes #35795, as part of #35233.

Excited to make my first contribution to rustc!

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 19, 2016

📌 Commit 39f318b has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 19, 2016
Update error format for E0232

Fixes rust-lang#35795, as part of rust-lang#35233.

Excited to make my first contribution to rustc!

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 19, 2016
Update error format for E0232

Fixes rust-lang#35795, as part of rust-lang#35233.

Excited to make my first contribution to rustc!

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 20, 2016
Update error format for E0232

Fixes rust-lang#35795, as part of rust-lang#35233.

Excited to make my first contribution to rustc!

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 20, 2016
Update error format for E0232

Fixes rust-lang#35795, as part of rust-lang#35233.

Excited to make my first contribution to rustc!

r? @jonathandturner
bors added a commit that referenced this pull request Aug 20, 2016
@bors bors merged commit 39f318b into rust-lang:master Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants