Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more evocative examples for Sub and SubAssign #35876

Merged
merged 1 commit into from
Aug 25, 2016

Conversation

matthew-piziak
Copy link
Contributor

These examples are exactly analogous to those in PRs #35709 and #35806. I'll probably remove the fn main wrappers for Add and Sub once this is merged in.

Part of #29365.

r? @steveklabnik

@GuillaumeGomez
Copy link
Member

Travis says:

---- ops::SubAssign_0 stdout ----
    error[E0368]: binary assignment operation `+=` cannot be applied to type `main::Point`
  --> <anon>:28:1
   |
28 | point += Point { x: 2, y: 3 };
   | ^^^^^ cannot use `+=` on type `main::Point`

error: aborting due to previous error(s)

@matthew-piziak
Copy link
Contributor Author

Oops! Fixed.

These examples are exactly analogous to those in PRs rust-lang#35709 and rust-lang#35806. I'll probably remove the `fn main` wrappers for `Add` and `Sub` once this is merged in.

Part of rust-lang#29365.

r? @steveklabnik
@GuillaumeGomez
Copy link
Member

Waiting confirmation from travis and then r+.

@matthew-piziak
Copy link
Contributor Author

@GuillaumeGomez Travis is green. 🍏 :)

@GuillaumeGomez
Copy link
Member

Great, thanks! :)

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 24, 2016

📌 Commit eb6d44d has been approved by GuillaumeGomez

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 24, 2016
…laumeGomez

more evocative examples for `Sub` and `SubAssign`

These examples are exactly analogous to those in PRs rust-lang#35709 and rust-lang#35806. I'll probably remove the `fn main` wrappers for `Add` and `Sub` once this is merged in.

Part of rust-lang#29365.

r? @steveklabnik
bors added a commit that referenced this pull request Aug 25, 2016
Rollup of 4 pull requests

- Successful merges: #35876, #35920, #35948, #35961
- Failed merges: #35395
@bors bors merged commit eb6d44d into rust-lang:master Aug 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants