Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update E0194 to new error format #36056

Merged
merged 1 commit into from
Aug 30, 2016
Merged

Update E0194 to new error format #36056

merged 1 commit into from
Aug 30, 2016

Conversation

leikahing
Copy link
Contributor

@leikahing leikahing commented Aug 27, 2016 •
edited
Loading

Fixes #35280 to update E0194 to support new error message format. Part of #35233.

A separate Github issue #36057 tracks the bonus portion of the original ticket.

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@leikahing
Copy link
Contributor Author

r? @jonathandturner

@sophiajt
Copy link
Contributor

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 28, 2016

📌 Commit eea03f5 has been approved by jonathandturner

@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 29, 2016
Closed
@bors
Copy link
Contributor

bors commented Aug 29, 2016

⌛ Testing commit eea03f5 with merge 4852d09...

@bors
Copy link
Contributor

bors commented Aug 29, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

@arielb1
Copy link
Contributor

arielb1 commented Aug 29, 2016

@bors retry rollup

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 29, 2016
@GuillaumeGomez
Rollup merge of rust-lang#36056 - birryree:E0194_new_error_format, r=…
11992c9 
…jonathandturner

Update E0194 to new error format

Fixes rust-lang#35280 to update E0194 to support new error message format. Part of rust-lang#35233.

A separate Github issue rust-lang#36057 tracks the bonus portion of the original ticket.

r? @jonathandturner
bors added a commit that referenced this pull request Aug 29, 2016
@bors
Auto merge of #36090 - GuillaumeGomez:rollup, r=GuillaumeGomez
aee9774 
Rollup of 11 pull requests

- Successful merges: #35418, #35759, #35862, #35863, #35962, #35977, #35993, #35997, #36054, #36056, #36070
- Failed merges: #35771, #35810
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 30, 2016
@GuillaumeGomez
Rollup merge of rust-lang#36056 - birryree:E0194_new_error_format, r=…
29c53a8 
…jonathandturner

Update E0194 to new error format

Fixes rust-lang#35280 to update E0194 to support new error message format. Part of rust-lang#35233.

A separate Github issue rust-lang#36057 tracks the bonus portion of the original ticket.

r? @jonathandturner
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 30, 2016
Merged
bors added a commit that referenced this pull request Aug 30, 2016
@bors
Auto merge of #36126 - GuillaumeGomez:rollup, r=GuillaumeGomez
badf406 
Rollup of 16 pull requests

- Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125
- Failed merges: #35771, #35810
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 30, 2016
@GuillaumeGomez
Rollup merge of rust-lang#36056 - birryree:E0194_new_error_format, r=…
751e4db 
…jonathandturner

Update E0194 to new error format

Fixes rust-lang#35280 to update E0194 to support new error message format. Part of rust-lang#35233.

A separate Github issue rust-lang#36057 tracks the bonus portion of the original ticket.

r? @jonathandturner
bors added a commit that referenced this pull request Aug 30, 2016
@bors
Auto merge of #36126 - GuillaumeGomez:rollup, r=GuillaumeGomez
4473130 
Rollup of 16 pull requests

- Successful merges: #35418, #35759, #35862, #35863, #35895, #35962, #35977, #35993, #35997, #36054, #36056, #36060, #36086, #36100, #36103, #36125
- Failed merges: #35771, #35810
@leikahing leikahing mentioned this pull request Aug 30, 2016
Closed
@bors bors merged commit eea03f5 into rust-lang:master Aug 30, 2016
@leikahing leikahing deleted the E0194_new_error_format branch August 30, 2016 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sophiajt sophiajt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@leikahing @rust-highfive @sophiajt @bors @arielb1 @nikomatsakis