llvm: backport "[SimplifyCFG] Hoisting invalidates metadata". #36117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💡 This pull request was already approved, no need to approve it again.
|
alexcrichton
added
the
beta-nominated
bors
added a commit
that referenced
this pull request
Aug 30, 2016
llvm: backport "[SimplifyCFG] Hoisting invalidates metadata". Fixes #36023 by backporting @majnemer's LLVM patch fixing [the LLVM bug](https://llvm.org/bugs/show_bug.cgi?id=29163.) where SimplifyCFG hoisted instructions andkept their metadata (conditional `!nonnull` loads could kill a null check later if hoisted). r? @alexcrichton
This was referenced Aug 30, 2016
Closed
| @@ -0,0 +1,32 @@ | |||
| // Copyright 2016 The Rust Project Developers. See the COPYRIGHT | |||
There was a problem hiding this comment.
This test fails on Travis CI. Any ideas why?
There was a problem hiding this comment.
Travis doesn't use the patched LLVM, so the test can't pass on it. See #36138.
nikomatsakis
added
the
beta-accepted
|
Accepting for backport. |
Merged
brson
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36023 by backporting @majnemer's LLVM patch fixing the LLVM bug where SimplifyCFG hoisted instructions andkept their metadata (conditional
!nonnullloads could kill a null check later if hoisted).r? @alexcrichton