Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 13 pull requests #36224

Closed
wants to merge 29 commits into from
Closed

Rollup of 13 pull requests #36224

wants to merge 29 commits into from

Commits on Aug 17, 2016

  1. Add must_use to the Reference

    QuietMisdreavus committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    0384722 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2016

  1. add links to interesting items in std::ptr documentation

    r? @steveklabnik
    
    add links for Box, Rc, and Vec
    matthew-piziak committed Aug 22, 2016
    Configuration menu
    Copy the full SHA
    33560ee View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2016

  1. demonstrate RHS != Self use cases for Add and Sub

    remove extra `../`s
    matthew-piziak committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    89f7e92 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2016

  1. remove references to zero_memory and copy_memory

    I can no longer find these methods in nightly docs.
    matthew-piziak committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    b5ce02c View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2016

  1. Normalize the function signature of closures

    Previously we didn't normalize the function signatures used for
    closures. This didn't cause a problem in most cases, but caused an ICE
    in during MIR type checking.
    
    Fixes rust-lang#36139
    Aatch committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    e0279d7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9a400f0 View commit details
    Browse the repository at this point in the history
  3. Special case a few colors for Windows

    Jonathan Turner committed Aug 31, 2016
    Configuration menu
    Copy the full SHA
    1b04762 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2016

  1. Update error message for lifetime of borrowed values

    Jonathan Turner committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    439afcd View commit details
    Browse the repository at this point in the history
  2. configure: check if any of the arguments contain --help

    Currently it checks only the first argument.
    
    Fixes rust-lang#31216
    0xmohit committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    7d5fa9e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0f8eb81 View commit details
    Browse the repository at this point in the history
  4. Fixed E0528 label and unit test

    Eugene R Gonzalez committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    7cd4e7f View commit details
    Browse the repository at this point in the history
  5. test: Add a min-llvm-version directive

    We've got tests which require a particular version of LLVM to run as they're
    testing bug fixes. Our build system, however, supports multiple LLVM versions,
    so we can't run these tests on all LLVM versions.
    
    This adds a new `min-llvm-version` directive for tests so they can opt out of
    being run on older versions of LLVM. This then namely applies that logic to the
    `issue-36023.rs` test case and...
    
    Closes rust-lang#36138
    alexcrichton committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    96283fc View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2016

  1. Fixed E0529's label and unit test

    Eugene R Gonzalez committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    7f95bb0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a96fe3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2f2df2a View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#35754 - QuietMisdreavus:must-use-reference,…

    … r=Manishearth
    
    Add `must_use` to the Reference
    
    I'm a bit uncertain about the exact phrasing, but having it mentioned at all is probably better than before.
    Jonathan Turner committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    23ef388 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#35793 - matthew-piziak:add-rhs-example, r=s…

    …teveklabnik
    
    demonstrate `RHS != Self` use cases for `Add` and `Sub`
    Jonathan Turner committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    2908ab2 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#35880 - matthew-piziak:ptr-linking, r=steve…

    …klabnik
    
    add links to interesting items in `std::ptr` documentation
    
    Part of rust-lang#29371.
    
    r? @steveklabnik
    Jonathan Turner committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    244a1e0 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#36099 - skade:better-try-documentation, r=s…

    …teveklabnik
    
    Document try!'s error conversion behaviour
    
    try!'s documentation currently doesn't document the error conversion behaviour of the macro. This patch extends the documentation.
    
    Open questions:
    * is it worthwhile to have seperate examples with and without wrapping behaviour? It's not immediately obvious that From<T> for T is always defined. Though this is necessary for the macro to work in any case, is this the place to expect that knowledge.
    Jonathan Turner committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    c77af26 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#36160 - Aatch:normalize-closure-sig, r=eddyb

    Normalize the function signature of closures
    
    Previously we didn't normalize the function signatures used for
    closures. This didn't cause a problem in most cases, but caused an ICE
    in during MIR type checking.
    
    Fixes rust-lang#36139
    
    r? @eddyb
    Jonathan Turner committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    d9893b3 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#36171 - jonathandturner:temporary_value, r=…

    …nikomatsakis
    
    Update lifetime errors to specifically note temporaries
    
    This PR updates the error message we give in the case of a temporary value not living long enough.
    
    Before:
    
    <img width="497" alt="screen shot 2016-08-31 at 10 02 47 am" src="https://cloud.githubusercontent.com/assets/547158/18138551/27a06794-6f62-11e6-9ee2-bdf8bed75ca7.png">
    
    Now:
    
    <img width="488" alt="screen shot 2016-08-31 at 10 03 01 am" src="https://cloud.githubusercontent.com/assets/547158/18138557/2e5cf322-6f62-11e6-9047-4a78abf3d78c.png">
    
    Specifically, it makes the following changes:
    
    * Detects if a temporary is being used.  If so, it changes the labels to mention that a temporary value specifically is in question
    * Simplifies wording of the existing labels to focus on lifetimes rather than values being valid
    * Changes the help to a note, since the help+span wasn't as helpful (and sometimes more confusing) than just a note.
    
    r? @nikomatsakis
    Jonathan Turner committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    0bbc6ec View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#36178 - jonathandturner:windows_colors, r=n…

    …ikomatsakis
    
    Special case a few colors for Windows
    
    As brought up on [this thread](rust-lang#33240 (comment)) the colors used in error messages on Windows can be difficult to read because of the lack of bold.
    
    This PR makes a few changes to improve readability, namely:
    * Rather than using BRIGHT_BLUE, on Windows we now use BRIGHT_CYAN, which is easier to read on black when you do not have bold
    * We used BRIGHT_YELLOW rather than YELLOW, for the same reason
    * Titles will be BRIGHT_WHITE now, to give the illusion of being bold
    
    Some examples:
    
    ![warning](https://cloud.githubusercontent.com/assets/547158/18148466/9aa9bbe2-6f8e-11e6-927f-d0eec53cac32.PNG)
    
    ![error](https://cloud.githubusercontent.com/assets/547158/18148488/ba9fb186-6f8e-11e6-8d8e-e93d569f61de.PNG)
    
    r? @nikomatsakis
    
    cc @retep998
    Jonathan Turner committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    29077e8 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#36180 - frewsxcv:patch-33, r=alexcrichton

    Transition Travis CI to use rustbuild.
    Jonathan Turner committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    4a8069d View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#36190 - 0xmohit:pr/issue-31216, r=alexcrichton

    configure: check if any of the arguments contain --help
    
    Currently it checks only the first argument.
    
    Fixes rust-lang#31216
    Jonathan Turner committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    c374d05 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#36198 - alexcrichton:fix-travis, r=brson

    test: Add a min-llvm-version directive
    
    We've got tests which require a particular version of LLVM to run as they're
    testing bug fixes. Our build system, however, supports multiple LLVM versions,
    so we can't run these tests on all LLVM versions.
    
    This adds a new `min-llvm-version` directive for tests so they can opt out of
    being run on older versions of LLVM. This then namely applies that logic to the
    `issue-36023.rs` test case and...
    
    Closes rust-lang#36138
    Jonathan Turner committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    9e60445 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#36205 - EugeneGonzalez:E0528, r=jonathandtu…

    …rner
    
    Fixed E0528 label and unit test
    
    Fixes rust-lang#36194 part of rust-lang#35233.
    
    r? @jonathandturner
    Jonathan Turner committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    5a1661a View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#36210 - EugeneGonzalez:E0529, r=jonathandtu…

    …rner
    
    Fixed E0529's label and unit test
    
    Fixes rust-lang#36195 part of rust-lang#35233.
    
    This is ready for review, but will likely fail Travis due to rust-lang#36138. I changed the wording of the label, so feedback on that would be appreciated.
    
    r? @jonathandturner
    Jonathan Turner committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    b2dc7b1 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#36223 - abhiQmar:e0558-formatting, r=jonath…

    …andturner
    
    Update compiler error E0558 to use new error format
    
    Fixes rust-lang#36196 part of rust-lang#35233
    
    r? @jonathandturner
    Jonathan Turner committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    5f2e32d View commit details
    Browse the repository at this point in the history
  17. Fix tidy warning

    Jonathan Turner committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    4f449e2 View commit details
    Browse the repository at this point in the history