Syntax breaking batch #36857
Merged
Syntax breaking batch #36857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe of other AstBuilder.stmt* functions
I am using `ThinAttributes` rather than a vector for attributes attached to generics, since I expect almost all lifetime and types parameters to not carry any attributes.
…ached binding in generics.
These weren't flagged by the lint because they were still technically created somewhere... if you created them before, somehow.
This applies the HIR changes from the previous commits to the AST, and is thus a syntax-[breaking-change] Renames `PatKind::Vec` to `PatKind::Slice`, since these are called slice patterns, not vec patterns. Renames `TyKind::Vec`, which represents the type `[T]`, to `TyKind::Slice`. Renames `TyKind::FixedLengthVec` to `TyKind::Array`.
|
@bors try |
|
💥 Test timed out |
|
@bors retry |
|
💥 Test timed out |
|
@bors try- r+ retry |
|
📌 Commit 173ebc3 has been approved by |
|
@bors p=10 |
|
⌛ Testing commit 173ebc3 with merge 5d3ae8a... |
…, r=Manishearth This commit makes the return type of AstBuilder.stmt_let_typed match the return type of other AstBuilder.stmt* functions. This avoids unnecessary boxing/unboxing whenever Stmt's are stored in a Vec, which is the default use case.nnThis is a potentially plugin breaking change.
…orite-data-structure, r=pnkfelix Contains a syntax-[breaking-change] as a separate commit (cc rust-lang#31645).nnAlso renames slice patterns from `PatKind::Vec` to `PatKind::Slice`.
…r=eddyb First step for rust-lang#34761
Manishearth
force-pushed
the
syntax-rollup
branch
from
173ebc3
to
406fe7e
Compare
|
@bors r+ force commit messages need r=foo |
|
📌 Commit 406fe7e has been approved by |
|
@bors force |
This was referenced Oct 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.