Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary fix for metadata decoding for struct constructors #37095

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Temporary fix for metadata decoding for struct constructors #37095

merged 1 commit into from
Oct 12, 2016

Conversation

petrochenkov
Copy link
Contributor

Same as #37078, but for nightly.
Ideally, metadata lookup functions should "just work" for constructor ids, but this fixes the issue as well.

Fixes #37026
r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Oct 11, 2016

📌 Commit f5827d0 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Oct 12, 2016

⌛ Testing commit f5827d0 with merge a29c49f...

bors added a commit that referenced this pull request Oct 12, 2016
@bors
Auto merge of #37095 - petrochenkov:metactor, r=alexcrichton
a29c49f 
Temporary fix for metadata decoding for struct constructors

Same as #37078, but for nightly.
Ideally, metadata lookup functions should "just work" for constructor ids, but this fixes the issue as well.

Fixes #37026
r? @alexcrichton
@bors
Copy link
Contributor

bors commented Oct 12, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing a29c49f to master...

@bors bors merged commit f5827d0 into rust-lang:master Oct 12, 2016
@alexcrichton alexcrichton mentioned this pull request Oct 12, 2016
Merged
@alexcrichton alexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 12, 2016
@alexcrichton
Copy link
Member

Nominating for "backport" which I believe is what #37078 is intending.

@brson brson added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Oct 14, 2016
@brson brson mentioned this pull request Oct 14, 2016
Merged
@petrochenkov petrochenkov deleted the metactor branch March 16, 2017 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
4 participants
@petrochenkov @alexcrichton @bors @brson