Redox Support Preview #37702

jackpot51 · 2016-11-11T03:43:55Z

Important - This is only a preview of a working `sys::redox`.

Compiling the Redox default distribution with this libstd results in a fully functioning distribution. As such, all further changes would be cosmetic or implementing features that have not been used by the default distribution (of which there are only a small number).

I do not expect this to be merged, but would like to discuss how it may be improved and get feedback.

There are a few unimplemented!() - cloexec for example. I have documented them below. These would be resolved before desiring a merge.

There are also issues with how the Redox syscall library is called - currently I am using a re-export in libc but that probably would not be desired.

… locals. Better error messages for unsupported features

rust-highfive · 2016-11-11T03:44:02Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

jackpot51 · 2016-11-11T03:47:03Z

@alexcrichton @brson @eddyb I am mentioning you here because you have expressed interest in a Redox libstd port

Previous discussion here: https://internals.rust-lang.org/t/redox-support-in-liblibc-and-libstd/3954/17

jackpot51 · 2016-11-11T03:57:56Z

src/libstd/sys_common/mod.rs

@@ -34,7 +34,6 @@ pub mod condvar;
 pub mod io;
 pub mod memchr;
 pub mod mutex;
-pub mod net;


Because Redox does networking using files, and does not support the traditional Berkeley Socket API, we must specify an alternative net module, which is defined in sys::redox::net and imported down below

jackpot51 · 2016-11-11T03:58:32Z

src/libstd/sys/redox/condvar.rs

+    #[inline]
+    pub fn wait_timeout(&self, _mutex: &Mutex, _dur: Duration) -> bool {
+        ::sys_common::util::dumb_print(format_args!("condvar wait_timeout\n"));
+        unimplemented!();


This will be implemented shortly with additional flags to futex

jackpot51 · 2016-11-11T03:58:49Z

src/libstd/sys/redox/fd.rs

+
+    pub fn set_cloexec(&self) -> io::Result<()> {
+        ::sys_common::util::dumb_print(format_args!("{}: set cloexec\n", self.fd));
+        unimplemented!();


This will be implemented shortly with an fcntl call

jackpot51 · 2016-11-11T03:59:03Z

src/libstd/sys/redox/fd.rs

+
+    pub fn set_nonblocking(&self, _nonblocking: bool) -> io::Result<()> {
+        ::sys_common::util::dumb_print(format_args!("{}: set nonblocking\n", self.fd));
+        unimplemented!();


This will be implemented shortly with an fcntl call

jackpot51 · 2016-11-11T03:59:18Z

src/libstd/sys/redox/fs.rs

+
+pub fn rename(_old: &Path, _new: &Path) -> io::Result<()> {
+    ::sys_common::util::dumb_print(format_args!("Rename\n"));
+    unimplemented!();


This will require a rename syscall

jackpot51 · 2016-11-11T03:59:29Z

src/libstd/sys/redox/fs.rs

+
+pub fn set_perm(_p: &Path, _perm: FilePermissions) -> io::Result<()> {
+    ::sys_common::util::dumb_print(format_args!("Set perm\n"));
+    unimplemented!();


This will require a chmod syscall

jackpot51 · 2016-11-11T03:59:46Z

src/libstd/sys/redox/fs.rs

+
+pub fn symlink(_src: &Path, _dst: &Path) -> io::Result<()> {
+    ::sys_common::util::dumb_print(format_args!("Symlink\n"));
+    unimplemented!();


Symlinks are not supported on Redox at the moment

In that case Err of some sort indicating that the operation is not supported should be returned (just like other OSes do when underlying filesystem does not support the operation).

jackpot51 · 2016-11-11T03:59:58Z

src/libstd/sys/redox/fs.rs

+
+pub fn link(_src: &Path, _dst: &Path) -> io::Result<()> {
+    ::sys_common::util::dumb_print(format_args!("Link\n"));
+    unimplemented!();


Hard links are not supported on Redox at the moment

jackpot51 · 2016-11-11T04:00:24Z

src/libstd/sys/redox/pipe.rs

+             _p2: AnonPipe,
+             _v2: &mut Vec<u8>) -> io::Result<()> {
+    ::sys_common::util::dumb_print(format_args!("read2\n"));
+    unimplemented!();


Due to using set_nonblocking, which is not supported until fcntl is added, this is not implemented yet

jackpot51 · 2016-11-11T04:01:08Z

src/libpanic_abort/lib.rs

@@ -28,7 +28,7 @@
 #![panic_runtime]
 #![feature(panic_runtime)]
 #![cfg_attr(unix, feature(libc))]
-#![cfg_attr(windows, feature(core_intrinsics))]
+#![cfg_attr(any(target_os = "redox", windows), feature(core_intrinsics))]


Redox has no libc function for abort, so using the intrinsic is required

jackpot51 · 2016-11-11T04:01:39Z

src/libpanic_unwind/lib.rs

@@ -69,6 +69,7 @@ mod imp;

 // i686-pc-windows-gnu and all others
 #[cfg(any(all(unix, not(target_os = "emscripten")),
+          target_os = "redox",


Redox could potentially use libunwind for backtraces. Right now, panic_abort is preferred.

jackpot51 · 2016-12-02T00:27:21Z

@alexcrichton Take, for instance, terminal auto completion. With Prefix the way it is in this patch, the autocompleter can correctly fill in paths that start with / like /bin/cat, relative paths like cat, as well as scheme-absolute paths like file:/bin/cat.

Without this patch, filling in file:/bin/cat will look for a folder named file: in the current directory.

Since scheme-absolute paths are not often used in this manner, I would be ok with putting off the decision until later - but it will introduce potential problems in some applications

alexcrichton · 2016-12-02T22:38:22Z

Well, I suppose it was just an idea. If it's require to have a custom prefix for redox, I don't know how to solve that problem in a good way.

brson · 2016-12-12T21:08:10Z

I think we're at an impasse for now on the prefix issue. Can we just remove prefixes from this patch to get the bulk of the work landed and circle back to the tough design question?

I'll go post a thread to irlo about expanding Prefix to raise awareness and see if anybody has bright ideas.

jackpot51 · 2016-12-12T21:16:59Z

@brson Sure

jackpot51 · 2016-12-12T21:24:20Z

@brson @alexcrichton The prefix handling has been removed. This must be readded in the future to avoid leaving in a potential security problem, but I would like to see a merge of Redox support before then as you have described.

brson · 2016-12-12T21:36:09Z

@bors r+

Thanks for your enduring patience.

bors · 2016-12-12T21:36:10Z

📌 Commit c61baa0 has been approved by brson

jackpot51 · 2016-12-12T21:53:18Z

Thanks @brson. I am going to work on adding the x86_64-unknown-redox target to rustc now.

jackpot51 · 2016-12-14T17:21:36Z

@brson, this job failed due to an issue fixed by #38340.

brson · 2016-12-14T17:45:16Z

@bors r+

bors · 2016-12-14T17:45:17Z

📌 Commit 3e15dc1 has been approved by brson

eddyb · 2016-12-15T04:51:30Z

@bors r=brson

bors · 2016-12-15T04:51:32Z

📌 Commit 3e15dc1 has been approved by brson

jackpot51 · 2016-12-15T04:51:49Z

thanks @eddyb

bors · 2016-12-15T06:23:13Z

⌛ Testing commit 3e15dc1 with merge cfa668f...

Redox Support Preview # Important - This is only a preview of a working `sys::redox`. Compiling the Redox default distribution with this `libstd` results in a fully functioning distribution. As such, all further changes would be cosmetic or implementing features that have not been used by the default distribution (of which there are only a small number). I do not expect this to be merged, but would like to discuss how it may be improved and get feedback. There are a few `unimplemented!()` - `cloexec` for example. I have documented them below. These would be resolved before desiring a merge. There are also issues with how the Redox syscall library is called - currently I am using a re-export in `libc` but that probably would not be desired.

bors · 2016-12-15T09:26:19Z

ticki · 2016-12-15T09:32:32Z

woohoo!

…ichton Redox: correct is_absolute() and has_root() This is awkward, but representing schemes properly in `Components` is not easily possible without breaking backwards compatibility, as discussed earlier in rust-lang#37702. But these methods can be corrected anyway.

jackpot51 added 16 commits October 27, 2016 20:57

Add redox system

8b09e01

Remove unsafe libc layer

a5de9bb

Can import unwind now

68fd7ee

Implement env, reentrant mutex, and partially implement scoped thread…

b1b35dd

… locals. Better error messages for unsupported features

Implement rand and args, cleanup other modules

ea6f5aa

Implement thread

37bfef0

Implement TLS scoped keys, compiler builtins

4edcddf

Fix for thread locals

c77979b

Merge branch 'master' of https://github.com/rust-lang/rust into redox

123d08b

Merge branch 'master' into redox

74dc845

Update to new sys requirements

01e8378

Fix exec

ced32a0

Fixes for stdio and processes on Redox

a908509

Fix readdir

79a8c27

Use target_os = redox for cfg

25e1a4a

Merge branch 'master' into redox

0bb9a95

rust-highfive assigned aturon Nov 11, 2016

jackpot51 commented Nov 11, 2016

View reviewed changes

Rollback prefix

056ebcc

Fix accidental removal of import

c61baa0

jackpot51 added 3 commits December 12, 2016 14:55

Merge branch 'master' into redox

7e7775c

Fix tidy checks

daaa231

Merge branch 'master' into redox

3e15dc1

jackpot51 mentioned this pull request Dec 14, 2016

Redox x86_64 target support #38366

Closed

jackpot51 force-pushed the redox branch from cf87de9 to 3e15dc1 Compare December 15, 2016 04:16

bors merged commit 3e15dc1 into rust-lang:master Dec 15, 2016

jackpot51 deleted the redox branch December 15, 2016 15:31

est31 mentioned this pull request Jan 10, 2017

1.15 release notes #38966

Merged

ids1024 mentioned this pull request Aug 18, 2017

Redox: correct is_absolute() and has_root() #43983

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redox Support Preview #37702

Redox Support Preview #37702

jackpot51 commented Nov 11, 2016 •

edited

Loading

rust-highfive commented Nov 11, 2016

jackpot51 commented Nov 11, 2016

jackpot51 Nov 11, 2016

jackpot51 Nov 11, 2016 •

edited

Loading

jackpot51 Nov 11, 2016

jackpot51 Nov 11, 2016

jackpot51 Nov 11, 2016

jackpot51 Nov 11, 2016

jackpot51 Nov 11, 2016

nagisa Nov 11, 2016

jackpot51 Nov 11, 2016

jackpot51 Nov 11, 2016

jackpot51 Nov 11, 2016 •

edited

Loading

jackpot51 Nov 11, 2016

jackpot51 commented Dec 2, 2016 •

edited

Loading

alexcrichton commented Dec 2, 2016

brson commented Dec 12, 2016

jackpot51 commented Dec 12, 2016

jackpot51 commented Dec 12, 2016

brson commented Dec 12, 2016

bors commented Dec 12, 2016

jackpot51 commented Dec 12, 2016

jackpot51 commented Dec 14, 2016 •

edited

Loading

brson commented Dec 14, 2016

bors commented Dec 14, 2016

eddyb commented Dec 15, 2016

bors commented Dec 15, 2016

jackpot51 commented Dec 15, 2016

bors commented Dec 15, 2016

bors commented Dec 15, 2016

ticki commented Dec 15, 2016

Redox Support Preview #37702

Redox Support Preview #37702

Conversation

jackpot51 commented Nov 11, 2016 • edited Loading

Important - This is only a preview of a working sys::redox.

rust-highfive commented Nov 11, 2016

jackpot51 commented Nov 11, 2016

Choose a reason for hiding this comment

jackpot51 Nov 11, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jackpot51 Nov 11, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jackpot51 commented Dec 2, 2016 • edited Loading

alexcrichton commented Dec 2, 2016

brson commented Dec 12, 2016

jackpot51 commented Dec 12, 2016

jackpot51 commented Dec 12, 2016

brson commented Dec 12, 2016

bors commented Dec 12, 2016

jackpot51 commented Dec 12, 2016

jackpot51 commented Dec 14, 2016 • edited Loading

brson commented Dec 14, 2016

bors commented Dec 14, 2016

eddyb commented Dec 15, 2016

bors commented Dec 15, 2016

jackpot51 commented Dec 15, 2016

bors commented Dec 15, 2016

bors commented Dec 15, 2016

ticki commented Dec 15, 2016

jackpot51 commented Nov 11, 2016 •

edited

Loading

Important - This is only a preview of a working `sys::redox`.

jackpot51 Nov 11, 2016 •

edited

Loading

jackpot51 Nov 11, 2016 •

edited

Loading

jackpot51 commented Dec 2, 2016 •

edited

Loading

jackpot51 commented Dec 14, 2016 •

edited

Loading