Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add regression test for #36168 #37919

Merged
merged 2 commits into from
Dec 4, 2016
Merged

add regression test for #36168 #37919

merged 2 commits into from
Dec 4, 2016

Conversation

nikomatsakis
Copy link
Contributor

@nikomatsakis
Copy link
Contributor Author

Travis failue does not look legit: https://api.travis-ci.org/jobs/177737188/log.txt?deansi=true

michaelwoerister
michaelwoerister reviewed Nov 21, 2016
View reviewed changes
Copy link
Member

@michaelwoerister michaelwoerister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me modulo the misleading comment and maybe the redundant impl.

src/test/incremental/add_private_fn_at_krate_root_cc/struct_point.rs

extern crate point;

/// A fn item that calls (public) methods on `Point` from the same impl which changed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since no impl is changed in this test case, really, I think one impl would be enough.

@nikomatsakis
Copy link
Contributor Author

@bors r=mw

@bors
Copy link
Contributor

bors commented Nov 28, 2016

📌 Commit 72fbf9f has been approved by mw

@nikomatsakis
Copy link
Contributor Author

@bors rollup

dns2utf8 added a commit to dns2utf8/rust that referenced this pull request Dec 1, 2016
@dns2utf8
Rollup merge of rust-lang#37919 - nikomatsakis:incremental-36168, r=mw
9709dba 
add regression test for rust-lang#36168

Fixes rust-lang#36168

r? @michaelwoerister
@dns2utf8 dns2utf8 mentioned this pull request Dec 1, 2016
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Dec 3, 2016
@frewsxcv
Rollup merge of rust-lang#37919 - nikomatsakis:incremental-36168, r=mw
8916acc 
add regression test for rust-lang#36168

Fixes rust-lang#36168

r? @michaelwoerister
@frewsxcv frewsxcv mentioned this pull request Dec 3, 2016
Merged
bors added a commit that referenced this pull request Dec 3, 2016
@bors
Auto merge of #38148 - frewsxcv:rollup, r=frewsxcv
28d6623 
Rollup of 15 pull requests

- Successful merges: #37859, #37919, #38020, #38028, #38029, #38065, #38073, #38077, #38089, #38090, #38096, #38112, #38113, #38130, #38141
- Failed merges:
@bors bors merged commit 72fbf9f into rust-lang:master Dec 4, 2016
@nikomatsakis nikomatsakis deleted the incremental-36168 branch April 14, 2017 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelwoerister michaelwoerister michaelwoerister left review comments

Assignees

@michaelwoerister michaelwoerister

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikomatsakis @bors @michaelwoerister