-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sparc64-linux support #38726
sparc64-linux support #38726
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@japaric If you rather want to debug on a real machine than on qemu, let me know. If you like, please join us in #sparc on Freenode. |
At a glance, the C ABI seems wrong; small structs should be passed in and returned in registers. |
@japaric Yes, backtrace of |
@jrtc27 It's very possible |
This seems good to me, thanks @japaric! I'm perpetually worried about all this cabi business though. It seems no one really knows what they're doing around the cabi modules and I'm reading "hello world works" as "someone's going to waste hours of their life later fixing an abi-related bug" |
@bors r+ |
📌 Commit b14785d has been approved by |
⌛ Testing commit b14785d with merge a2930da... |
💔 Test failed - status-travis |
@bors retry Network failure. |
sparc64-linux support This is built on top of #38656 and depends on rust-lang/libc#483 Hello world works. The libc-test test suite passes. `panic!` doesn't fully work: ``` $ qemu-sparc64-static ./panic thread 'main' panicked at 'explicit panic', panic.rs:1 note: Run with `RUST_BACKTRACE=1` for a backtrace. Illegal instruction (core dumped) ``` Backtraces don't work either, probably related to the previous point: ``` $ export RUST_BACKTRACE=1 $ qemu-sparc64-static ./panic thread 'main' panicked at 'explicit panic', panic.rs:1 stack backtrace: Illegal instruction (core dumped) ``` r? @alexcrichton @jakllsch Does panicking / backtraces work on sparc64-netbsd? cc @glaubitz
☀️ Test successful - status-appveyor, status-travis |
This is built on top of #38656 and depends on rust-lang/libc#483
Hello world works.
The libc-test test suite passes.
panic!
doesn't fully work:Backtraces don't work either, probably related to the previous point:
r? @alexcrichton
@jakllsch Does panicking / backtraces work on sparc64-netbsd?
cc @glaubitz