std: Relax UnwindSafe impl for Unique #40020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `?Sized` bound as we don't require the type to be sized. Closes rust-lang#40011
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
|
Nominating for a beta backport as well as the linked issue is a beta regression |
alexcrichton
added
the
beta-nominated
|
@bors r+ (boo |
|
📌 Commit 347e1af has been approved by |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Feb 25, 2017
…ckler std: Relax UnwindSafe impl for Unique Add the `?Sized` bound as we don't require the type to be sized. Closes rust-lang#40011
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Feb 25, 2017
…ckler std: Relax UnwindSafe impl for Unique Add the `?Sized` bound as we don't require the type to be sized. Closes rust-lang#40011
bors
added a commit
that referenced
this pull request
Feb 25, 2017
Rollup of 28 pull requests - Successful merges: #39859, #39864, #39888, #39903, #39905, #39914, #39945, #39950, #39953, #39961, #39980, #39988, #39993, #39995, #40019, #40020, #40022, #40024, #40025, #40026, #40027, #40031, #40035, #40037, #40038, #40064, #40069, #40086 - Failed merges: #39927, #40008, #40047
|
Accepting for a backport as it's a regression |
alexcrichton
added
the
beta-accepted
Merged
alexcrichton
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Mar 2, 2017
[beta] next - #39913 - #39730 - #39674 - #39602 - #39586 - #39471 - #39980 - #40020 - #40135 @nikomatsakis [this commit](3787d33) did not pick cleanly. You might peek at it. I took the liberty of accepting all the nominations myself, but the [packed struct alignment](#39586) PR is quite large. It did pick fine though and there's a comment there suggesting it works on beta cc @rust-lang/compiler. cc @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
?Sizedbound as we don't require the type to be sized.Closes #40011