New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify thread::Builder::stack_size docs #40030

Merged

bors merged 1 commit into rust-lang:master from matklad:stack-docs

Feb 25, 2017

Member

matklad commented Feb 22, 2017

Add two pieces of information:

the size is in bytes
the actual stack size might be bigger.

Also change the example to use a more realistic value of 32 kilobytes.

r? @steveklabnik


          Clarify thread::Builder::stack_size

689dc26

rust-highfive assigned steveklabnik

Member Author

matklad commented Feb 22, 2017

Platform-dependent minimum on unix is set here:

rust/src/libstd/sys/unix/thread.rs

Line 54 in fc6f092

let stack_size = cmp::max(stack, min_stack_size(&attr));

Member

alexcrichton commented Feb 22, 2017

Contributor

bors commented Feb 22, 2017

📌 Commit 689dc26 has been approved by alexcrichton

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request


          Rollup merge of rust-lang#40030 - matklad:stack-docs, r=alexcrichton

708da3e

Clarify thread::Builder::stack_size docs

Add two pieces of information:

* the size is in bytes
* the actual stack size might be bigger.

Also change the example to use a more realistic value of 32 kilobytes.

r? @steveklabnik

GuillaumeGomez mentioned this pull request

Rollup of 10 pull requests #40040

Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request


          Rollup merge of rust-lang#40030 - matklad:stack-docs, r=alexcrichton

c6ce7b4

Clarify thread::Builder::stack_size docs

Add two pieces of information:

* the size is in bytes
* the actual stack size might be bigger.

Also change the example to use a more realistic value of 32 kilobytes.

r? @steveklabnik

frewsxcv mentioned this pull request

Rollup of 11 pull requests #40045

Closed

bors added a commit that referenced this pull request


          Auto merge of #40045 - frewsxcv:rollup, r=frewsxcv

dd1c546

Rollup of 11 pull requests

- Successful merges: #39859, #39886, #39892, #39903, #39914, #39918, #39988, #40010, #40027, #40030, #40035
- Failed merges:

Member

GuillaumeGomez commented Feb 23, 2017

@bors: rollup

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request


          Rollup merge of rust-lang#40030 - matklad:stack-docs, r=alexcrichton

dcd5c55

Clarify thread::Builder::stack_size docs

Add two pieces of information:

* the size is in bytes
* the actual stack size might be bigger.

Also change the example to use a more realistic value of 32 kilobytes.

r? @steveklabnik

GuillaumeGomez mentioned this pull request

Rollup of 6 pull requests #40053

Closed

frewsxcv added a commit to frewsxcv/rust that referenced this pull request


          Rollup merge of rust-lang#40030 - matklad:stack-docs, r=alexcrichton

ff96ca1

Clarify thread::Builder::stack_size docs

Add two pieces of information:

* the size is in bytes
* the actual stack size might be bigger.

Also change the example to use a more realistic value of 32 kilobytes.

r? @steveklabnik

frewsxcv mentioned this pull request

Rollup of 10 pull requests #40059

Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request


          Rollup merge of rust-lang#40030 - matklad:stack-docs, r=alexcrichton

ef4d27d

Clarify thread::Builder::stack_size docs

Add two pieces of information:

* the size is in bytes
* the actual stack size might be bigger.

Also change the example to use a more realistic value of 32 kilobytes.

r? @steveklabnik

GuillaumeGomez mentioned this pull request

Rollup of 11 pull requests #40072

Merged

frewsxcv added a commit to frewsxcv/rust that referenced this pull request


          Rollup merge of rust-lang#40030 - matklad:stack-docs, r=alexcrichton

26643dd

Clarify thread::Builder::stack_size docs

Add two pieces of information:

* the size is in bytes
* the actual stack size might be bigger.

Also change the example to use a more realistic value of 32 kilobytes.

r? @steveklabnik

frewsxcv mentioned this pull request

Rollup of 17 pull requests #40080

Closed

bors added a commit that referenced this pull request


          Auto merge of #40080 - frewsxcv:rollup, r=frewsxcv

c9d3749

Rollup of 17 pull requests

- Successful merges: #39777, #39815, #39845, #39886, #39892, #39903, #39905, #39914, #39927, #39940, #40010, #40030, #40048, #40050, #40052, #40060, #40071
- Failed merges:

bors added a commit that referenced this pull request


          Auto merge of #40072 - GuillaumeGomez:rollup, r=GuillaumeGomez

Rollup of 11 pull requests

- Successful merges: #39777, #39815, #39845, #39886, #39940, #40010, #40030, #40048, #40050, #40052, #40071
- Failed merges:

bors merged commit 689dc26 into rust-lang:master

matklad deleted the stack-docs branch

July 9, 2019 12:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet