Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Exit quickly on only --emit dep-info #40336

Merged
merged 1 commit into from
Mar 11, 2017

Conversation

alexcrichton
Copy link
Member

This commit alters the compiler to exit quickly if the only output being emitted
is dep-info, which doesn't need a lot of other information to generate.

Closes #40328

@rust-highfive
Copy link
Collaborator

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @nrc

This may not be the best method of doing so, but I figured you'd likely know the right direction!

@rust-highfive rust-highfive assigned nrc and unassigned arielb1 Mar 7, 2017
@nrc
Copy link
Member

nrc commented Mar 8, 2017

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 8, 2017

📌 Commit 12dee0e has been approved by nrc

@luser
Copy link
Contributor

luser commented Mar 8, 2017

@eddyb had suggested that the right place for a fix would be to set control.after_hir_lowering.stop like is done here:

if sess.opts.debugging_opts.no_analysis ||
sess.opts.debugging_opts.ast_json {
control.after_hir_lowering.stop = Compilation::Stop;
}
if !sess.opts.output_types.keys().any(|&i| i == OutputType::Exe ||
i == OutputType::Metadata) {
control.after_llvm.stop = Compilation::Stop;
}

@eddyb
Copy link
Member

eddyb commented Mar 8, 2017

Both approaches are valid FWIW, I don't mind this landing.

@eddyb
Copy link
Member

eddyb commented Mar 8, 2017

@rust-lang/tools Do we want to backport this so it's fixed in the next stable? Or is that too risky?

@alexcrichton
Copy link
Member Author

I'd personally be fine either way, but the next stable is real soon

@bors
Copy link
Contributor

bors commented Mar 9, 2017

🔒 Merge conflict

@alexcrichton
Copy link
Member Author

@bors: retry

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 9, 2017
rustc: Exit quickly on only `--emit dep-info`

This commit alters the compiler to exit quickly if the only output being emitted
is `dep-info`, which doesn't need a lot of other information to generate.

Closes rust-lang#40328
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017
rustc: Exit quickly on only `--emit dep-info`

This commit alters the compiler to exit quickly if the only output being emitted
is `dep-info`, which doesn't need a lot of other information to generate.

Closes rust-lang#40328
alexcrichton pushed a commit to arielb1/rust that referenced this pull request Mar 10, 2017
rustc: Exit quickly on only `--emit dep-info`

This commit alters the compiler to exit quickly if the only output being emitted
is `dep-info`, which doesn't need a lot of other information to generate.

Closes rust-lang#40328
This commit alters the compiler to exit quickly if the only output being emitted
is `dep-info`, which doesn't need a lot of other information to generate.

Closes rust-lang#40328
@alexcrichton
Copy link
Member Author

@bors: r=nrc

@bors
Copy link
Contributor

bors commented Mar 10, 2017

📌 Commit 5c8aa74 has been approved by nrc

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 10, 2017
rustc: Exit quickly on only `--emit dep-info`

This commit alters the compiler to exit quickly if the only output being emitted
is `dep-info`, which doesn't need a lot of other information to generate.

Closes rust-lang#40328
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 11, 2017
rustc: Exit quickly on only `--emit dep-info`

This commit alters the compiler to exit quickly if the only output being emitted
is `dep-info`, which doesn't need a lot of other information to generate.

Closes rust-lang#40328
@bors bors merged commit 5c8aa74 into rust-lang:master Mar 11, 2017
@alexcrichton alexcrichton deleted the fast-dep-info branch March 17, 2017 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants