Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library stabilizations for 1.17 #40538

Merged
merged 9 commits into from
Mar 19, 2017
Merged

Library stabilizations for 1.17 #40538

merged 9 commits into from
Mar 19, 2017

Conversation

aturon
Copy link
Member

@aturon aturon commented Mar 15, 2017

Details of the stabilizations are available in the commits. Includes only library stabilizations; there are a couple of compiler stabilizations that should also be done for 1.17.

Will need a beta backport, which I will create after approval.

r? @alexcrichton

@alexcrichton alexcrichton added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Mar 15, 2017
@alexcrichton
Copy link
Member

@bors: r+ p=1

Looks good to me, I pushed a commit as well to fix some tidy errors and missed one API (BTreeSet::range)

@bors
Copy link
Contributor

bors commented Mar 15, 2017

📌 Commit 4a22b56 has been approved by alexcrichton

@alexcrichton
Copy link
Member

(btw p=1 for the beta nomination)

@ollie27
Copy link
Member

ollie27 commented Mar 15, 2017

Shouldn't the btree_map::Range, btree_map::RangeMut and btree_set::Range structs and the trait impls for them also be stabilised?

@alexcrichton
Copy link
Member

@ollie27 good catch, I'll update those (thanks for the sharp eye!)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 15, 2017

📌 Commit 3d8d376 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40538 - aturon:stab-1.17, r=alexcrichton
fc635ae 
Library stabilizations for 1.17

Details of the stabilizations are available in the commits. Includes only library stabilizations; there are a couple of compiler stabilizations that should also be done for 1.17.

Will need a beta backport, which I will create after approval.

r? @alexcrichton
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40538 - aturon:stab-1.17, r=alexcrichton
491a32f 
Library stabilizations for 1.17

Details of the stabilizations are available in the commits. Includes only library stabilizations; there are a couple of compiler stabilizations that should also be done for 1.17.

Will need a beta backport, which I will create after approval.

r? @alexcrichton
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40538 - aturon:stab-1.17, r=alexcrichton
5616df5 
Library stabilizations for 1.17

Details of the stabilizations are available in the commits. Includes only library stabilizations; there are a couple of compiler stabilizations that should also be done for 1.17.

Will need a beta backport, which I will create after approval.

r? @alexcrichton
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40538 - aturon:stab-1.17, r=alexcrichton
eba6c1f 
Library stabilizations for 1.17

Details of the stabilizations are available in the commits. Includes only library stabilizations; there are a couple of compiler stabilizations that should also be done for 1.17.

Will need a beta backport, which I will create after approval.

r? @alexcrichton
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
@arielb1
Copy link
Contributor

arielb1 commented Mar 17, 2017 

failures:

---- range.rs - range::RangeArgument::end (line 52) stdout ----

	error: this feature has been stable since 1.17.0. Attribute no longer needed

 --> <anon>:3:12

  |

3 | #![feature(collections_bound)]

  |            ^^^^^^^^^^^^^^^^^

  |

  = note: #[deny(stable_features)] implied by #[deny(warnings)]

note: lint level defined here

 --> <anon>:6:9

  |

6 | #![deny(warnings)]

  |         ^^^^^^^^

error: aborting due to previous error(s)

thread 'rustc' panicked at 'Box<Any>', /checkout/src/librustc/session/mod.rs:203

note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- range.rs - range::RangeArgument::start (line 29) stdout ----

	error: this feature has been stable since 1.17.0. Attribute no longer needed

 --> <anon>:3:12

  |

3 | #![feature(collections_bound)]

  |            ^^^^^^^^^^^^^^^^^

  |

  = note: #[deny(stable_features)] implied by #[deny(warnings)]

note: lint level defined here

 --> <anon>:6:9

  |

6 | #![deny(warnings)]

  |         ^^^^^^^^

@bors r-

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 17, 2017

📌 Commit fcd5f1d has been approved by alexcrichton

@alexcrichton
Copy link
Member

@bor: r+

@alexcrichton alexcrichton mentioned this pull request Mar 17, 2017
Merged
@frewsxcv frewsxcv mentioned this pull request Mar 18, 2017
Closed
@frewsxcv
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Mar 18, 2017

⌛ Testing commit 1241a88 with merge b62d33f...

arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 18, 2017
Rollup merge of rust-lang#40538 - aturon:stab-1.17, r=alexcrichton
c2e6d72 
Library stabilizations for 1.17

Details of the stabilizations are available in the commits. Includes only library stabilizations; there are a couple of compiler stabilizations that should also be done for 1.17.

Will need a beta backport, which I will create after approval.

r? @alexcrichton
@arielb1 arielb1 mentioned this pull request Mar 18, 2017
Closed
@arielb1
Copy link
Contributor

arielb1 commented Mar 18, 2017

@bors retry

bors added a commit that referenced this pull request Mar 18, 2017
@bors
Auto merge of #40644 - arielb1:rollup, r=arielb1
1d565ef 
Rollup of 22 pull requests

- Successful merges: #40241, #40346, #40348, #40377, #40398, #40409, #40441, #40445, #40509, #40521, #40523, #40532, #40538, #40564, #40581, #40583, #40588, #40589, #40590, #40603, #40611, #40621
- Failed merges: #40501, #40541
@bors
Copy link
Contributor

bors commented Mar 19, 2017

⌛ Testing commit 1241a88 with merge 2876f08...

@arielb1 arielb1 mentioned this pull request Mar 19, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Mar 19, 2017
Rollup merge of rust-lang#40538 - aturon:stab-1.17, r=alexcrichton
eef8130 
Library stabilizations for 1.17

Details of the stabilizations are available in the commits. Includes only library stabilizations; there are a couple of compiler stabilizations that should also be done for 1.17.

Will need a beta backport, which I will create after approval.

r? @alexcrichton
@arielb1
Copy link
Contributor

arielb1 commented Mar 19, 2017

@bors retry

@bors
Copy link
Contributor

bors commented Mar 19, 2017

⌛ Testing commit 1241a88 with merge 18445a3...

@arielb1
Copy link
Contributor

arielb1 commented Mar 19, 2017

@bors retry

@bors
Copy link
Contributor

bors commented Mar 19, 2017

⌛ Testing commit 1241a88 with merge bfc49b1...

bors added a commit that referenced this pull request Mar 19, 2017
@bors
Auto merge of #40538 - aturon:stab-1.17, r=alexcrichton
bfc49b1 
Library stabilizations for 1.17

Details of the stabilizations are available in the commits. Includes only library stabilizations; there are a couple of compiler stabilizations that should also be done for 1.17.

Will need a beta backport, which I will create after approval.

r? @alexcrichton
@bors
Copy link
Contributor

bors commented Mar 19, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing bfc49b1 to master...

@bors bors merged commit 1241a88 into rust-lang:master Mar 19, 2017
This was referenced Mar 19, 2017
Merged
Closed
Merged
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 20, 2017
@RalfJung RalfJung mentioned this pull request Jan 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aturon @alexcrichton @bors @ollie27 @arielb1 @frewsxcv