Some preparations for directly computing the ICH of crate-metadata. #40678
Conversation
src/librustc/ty/util.rs
Outdated
| } | ||
| ty::ReErased | | ||
| ty::ReStatic | | ||
| ty::ReEmpty => {} |
There was a problem hiding this comment.
Nit: can you add a blank line in the {} block? This formatting makes it hard to see that the arms are a distinct group from the line below.
| Rvalue::Ref(ref mut r, _, _) => { | ||
| *r = self.tcx.mk_region(ReErased); | ||
| } | ||
| _ => { |
There was a problem hiding this comment.
I feel like this is a classic case where it'd be good to enumerate the Rvalue variants (so that if a new variant is added, or a variant changes, we are likely to notice this case)
|
r=me if the match is made exhaustive |
|
@bors r=nikomatsakis |
|
📌 Commit 00fed35 has been approved by |
|
🔒 Merge conflict |
|
There's a submodule conflict causing some mass PR invalidations, but rebasing reveals many other conflicts which I don't feel comfortable fixing myself (I already feel dirty enough rebasing commits in other people's repos...). |
|
@bors r=nikomatsakis |
|
📌 Commit c9a61b1 has been approved by |
michaelwoerister
force-pushed
the
dmi-prep
branch
from
c9a61b1
to
45deab4
Compare
|
@bors r=nikomatsakis Rebased |
|
📌 Commit 45deab4 has been approved by |
…tsakis Some preparations for directly computing the ICH of crate-metadata. This PR contains some small fixes in preparation for direct metadata hashing. It mostly just moves stuff into places where it will be needed (making the module structure slightly cleaner along the way) and it fixes some omissions in the MIR region eraser. r? @nikomatsakis
This PR contains some small fixes in preparation for direct metadata hashing. It mostly just moves stuff into places where it will be needed (making the module structure slightly cleaner along the way) and it fixes some omissions in the MIR region eraser.
r? @nikomatsakis