Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

str: Make docs consistently punctuated #40692

Merged
merged 1 commit into from
Mar 23, 2017
Merged

str: Make docs consistently punctuated #40692

merged 1 commit into from
Mar 23, 2017

Conversation

SamWhited
Copy link
Contributor

@SamWhited SamWhited commented Mar 21, 2017

Every so slightly pointless one character PR, but this was driving me nuts while reading the docs a moment ago (all the other public structs have descriptions that end in a full-stop).

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 21, 2017

📌 Commit e3da6e7 has been approved by frewsxcv

@SamWhited
Copy link
Contributor Author

Travis apparently hiccuped, but I don't have the authority to kick it.

@frewsxcv
Copy link
Member

I could kick it, but I'm pretty sure your changes won't fail any tests, so probably not worth a two hour build ;)

Your changes are queued up to be tested and merged: https://buildbot2.rust-lang.org/homu/queue/rust

@bors
Copy link
Contributor

bors commented Mar 21, 2017

🔒 Merge conflict

@bstrie
Copy link
Contributor

bstrie commented Mar 21, 2017

I've rebased this branch due to a submodule conflict that invalidated many PRs.

@bstrie
Copy link
Contributor

bstrie commented Mar 21, 2017

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 21, 2017

📌 Commit 49db656 has been approved by bstrie

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 22, 2017
…uation, r=bstrie

str: Make docs consistently punctuated

Every so slightly pointless one character PR, but this was driving me nuts while reading the docs a moment ago (all the [other public structs](https://doc.rust-lang.org/std/str/index.html#structs) have descriptions that end in a full-stop).
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 22, 2017
…uation, r=bstrie

str: Make docs consistently punctuated

Every so slightly pointless one character PR, but this was driving me nuts while reading the docs a moment ago (all the [other public structs](https://doc.rust-lang.org/std/str/index.html#structs) have descriptions that end in a full-stop).
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 22, 2017
…uation, r=bstrie

str: Make docs consistently punctuated

Every so slightly pointless one character PR, but this was driving me nuts while reading the docs a moment ago (all the [other public structs](https://doc.rust-lang.org/std/str/index.html#structs) have descriptions that end in a full-stop).
bors added a commit that referenced this pull request Mar 22, 2017
Rollup of 13 pull requests

- Successful merges: #40509, #40523, #40548, #40578, #40619, #40689, #40690, #40692, #40704, #40722, #40723, #40725, #40732
- Failed merges:
@bors bors merged commit 49db656 into rust-lang:master Mar 23, 2017
@SamWhited SamWhited deleted the consistent_str_docs_punctuation branch March 23, 2017 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants