travis: Split all dist builders in two #40998
Conversation
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson |
alexcrichton
force-pushed
the
split-dist
branch
2 times, most recently
from
21c3fd8
to
1959321
Compare
src/ci/docker/run.sh
Outdated
| @@ -45,20 +45,20 @@ else | |||
| args="$args --env SCCACHE_DIR=/sccache --volume $HOME/.cache/sccache:/sccache" | |||
| fi | |||
|
|
|||
| exec docker \ | |||
| run \ | |||
There was a problem hiding this comment.
Indeed this is much faster, about 4min30sec total for the ALLOW_PR builder. But I'm not sure that disabling the docker run entirely is intentional?
There was a problem hiding this comment.
Blast my attempt to improve our ci by 100000% percent has been foiled!
(definition not intentional to leave this change in)
| @@ -1,63 +0,0 @@ | |||
| From 2739047682590b1df473401b4febf424f857fccf Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
Did you mean to drop this s390x patch?
There was a problem hiding this comment.
Heh that'd explain why it failed on the bots, forgot we had a gitignore for *.patch
Previously we would use one builder on Travis to produce two sets of host compilers for two different targets. Unfortunately though we've recently increased how much we're building for each target so this is starting to take unnecessarily long (rust-lang#40804). This commit splits the dist builders in two by ensuring that we only dist one target on each builder, which should take a much shorter amount of time. This should also unblock other work such as landing the RLS (rust-lang#40584).
|
📌 Commit 541512b has been approved by |
travis: Split all dist builders in two Previously we would use one builder on Travis to produce two sets of host compilers for two different targets. Unfortunately though we've recently increased how much we're building for each target so this is starting to take unnecessarily long (rust-lang#40804). This commit splits the dist builders in two by ensuring that we only dist one target on each builder, which should take a much shorter amount of time. This should also unblock other work such as landing the RLS (rust-lang#40584).
|
Failure on |
|
Follow up from my last comment, this should fix the issue: |
Previously we would use one builder on Travis to produce two sets of host
compilers for two different targets. Unfortunately though we've recently
increased how much we're building for each target so this is starting to take
unnecessarily long (#40804). This commit splits the dist builders in two by
ensuring that we only dist one target on each builder, which should take a much
shorter amount of time. This should also unblock other work such as landing the
RLS (#40584).