Fix Markdown issues in the docs #41111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Since the switch to pulldown-cmark reference links need a blank line before the URLs. * Reference link references are not case sensitive. * Doc comments need to be indented uniformly otherwise rustdoc gets confused.
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
This was referenced Apr 6, 2017
|
Thanks! @bors: r+ rollup |
|
📌 Commit b4be475 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 6, 2017
…umeGomez Fix Markdown issues in the docs * Since the switch to pulldown-cmark reference links need a blank line before the URLs. (rust-lang#40912) * Reference link references are not case sensitive. * Doc comments need to be indented uniformly otherwise rustdoc gets confused.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 6, 2017
…umeGomez Fix Markdown issues in the docs * Since the switch to pulldown-cmark reference links need a blank line before the URLs. (rust-lang#40912) * Reference link references are not case sensitive. * Doc comments need to be indented uniformly otherwise rustdoc gets confused.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 6, 2017
rustdoc: Use pulldown-cmark for Markdown HTML rendering Instead of rendering all of the HTML in rustdoc this relies on pulldown-cmark's `push_html` to do most of the work. A few iterator adapters are used to make rustdoc specific modifications to the output. This also fixes MarkdownHtml and link titles in plain_summary_line. https://ollie27.github.io/rust_doc_test/ is the docs built with this change and rust-lang#41111. Part of rust-lang#40912. cc @GuillaumeGomez r? @steveklabnik
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 6, 2017
…umeGomez Fix Markdown issues in the docs * Since the switch to pulldown-cmark reference links need a blank line before the URLs. (rust-lang#40912) * Reference link references are not case sensitive. * Doc comments need to be indented uniformly otherwise rustdoc gets confused.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 6, 2017
rustdoc: Use pulldown-cmark for Markdown HTML rendering Instead of rendering all of the HTML in rustdoc this relies on pulldown-cmark's `push_html` to do most of the work. A few iterator adapters are used to make rustdoc specific modifications to the output. This also fixes MarkdownHtml and link titles in plain_summary_line. https://ollie27.github.io/rust_doc_test/ is the docs built with this change and rust-lang#41111. Part of rust-lang#40912. cc @GuillaumeGomez r? @steveklabnik
bors
added a commit
that referenced
this pull request
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before the URLs. (Tracking issue for hoedown -> pulldown regressions #40912)
confused.