bootstrap.py: fix armv7 detection #41152
Conversation
This matches the logic that was in `./configure` before f8ca805.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| cputype = 'arm' | ||
| ostype += 'eabihf' | ||
| elif cputype == 'armv7l': | ||
| elif cputype in {'armv7l', 'armv8l'}: |
There was a problem hiding this comment.
I think that cputype for armv8l should be aarch64. See https://www.reddit.com/r/rust/comments/631bl2/exciting_rust_coming_to_android_and_chromebooks/dfrvl0j/
There was a problem hiding this comment.
armv8l is still running in 32-bit mode. If you're running 64-bit, uname -m should say aarch64.
I just verified this on my Galaxy S7. When I run uname -m via adb shell, I get aarch64. When I run under JuiceSSH localhost, I get armv8l. Last time I checked, Termux only installed a 32-bit environment, which might explain why you don't see aarch64.
There was a problem hiding this comment.
That said, I just tried Termux myself, and I do see aarch64. From their changelog it seems they started installing 64-bit about a year ago. Perhaps your installation predates this?
Start using 64-bit arm packages for capable devices. Up until now Termux used 32-bit arm binaries even on 64-bit devices. This change will affect only new installations - existing users may reinstall the app to get a 64-bit environment (making sure to save relevant material from the home folder first).
There was a problem hiding this comment.
That is not my device... Do you have any idea of why does JuiceSSH differs from termux?
There was a problem hiding this comment.
I didn't mean that it was your device, just that it's the 64-bit Android I have at hand. I think the difference is simply that JuiceSSH is a 32-bit app, and my Termux installation got 64-bit.
There was a problem hiding this comment.
I misunderstood you. My english is not very good, sorry. Thank you once again.
|
@bors r+ |
|
📌 Commit 5c0c3e8 has been approved by |
|
Nice catch, @cuviper! |
|
⌛ Testing commit 5c0c3e8 with merge 85a9d75... |
|
💔 Test failed - status-appveyor |
bootstrap.py: fix armv7 detection This matches the logic that was in `./configure` before f8ca805.
This matches the logic that was in
./configurebefore f8ca805.