ci: Update android ndk and sdk #41863
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Why not use the latest stable versions i.e. NDK r14b, SDK r26.0.2? |
|
NDK r14b are deprecating gcc, so I though it would be better to stay with r13b for while. SDK r25.3 removed |
|
@bors: r+ Looks great! If you'd like to look into having the containers share files as well (e.g. to avoid this script duplication) I'd also be totally on board with that, but I'm also fine having duplication for now as well. |
|
📌 Commit 49f793a has been approved by |
Oh, that's funny that you asked it. I was about to open a issue about it. After this got merged I will open a PR then, so you can see what's my idea about a migration path to shared files. |
|
👍 I think you'll find... a nontrivial amount of duplication! Don't feel the need to tackle it all at once though, we can do this incrementally. |
…alexcrichton ci: Update android ndk and sdk Make install-sdk.sh and install-ndk.sh more generic so future updates can be made directly on Dockerfile. Update ndk to r13b, which will be necessary to make host builds for android (in the future). Update sdk to r25.2.5 (maybe some emulator performance improvement).
…alexcrichton ci: Update android ndk and sdk Make install-sdk.sh and install-ndk.sh more generic so future updates can be made directly on Dockerfile. Update ndk to r13b, which will be necessary to make host builds for android (in the future). Update sdk to r25.2.5 (maybe some emulator performance improvement).
TimNN
added
the
S-waiting-on-bors
…alexcrichton ci: Update android ndk and sdk Make install-sdk.sh and install-ndk.sh more generic so future updates can be made directly on Dockerfile. Update ndk to r13b, which will be necessary to make host builds for android (in the future). Update sdk to r25.2.5 (maybe some emulator performance improvement).
ci: Update android ndk and sdk Make install-sdk.sh and install-ndk.sh more generic so future updates can be made directly on Dockerfile. Update ndk to r13b, which will be necessary to make host builds for android (in the future). Update sdk to r25.2.5 (maybe some emulator performance improvement).
|
☀️ Test successful - status-appveyor, status-travis |
Make install-sdk.sh and install-ndk.sh more generic so future updates can be made directly on Dockerfile. Update ndk to r13b, which will be necessary to make host builds for android (in the future). Update sdk to r25.2.5 (maybe some emulator performance improvement).