Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Fix implementors list javascript #42096

Merged
merged 1 commit into from
May 19, 2017

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented May 19, 2017

  • Use a different loop variable, i was already taken. This caused
    missing items in the implementors list.
  • Use .getAttribute('href') rather than .href to get the relative
    URL which is what it needs to actually fix the links.

More fallout from #41307.

r? @GuillaumeGomez

* Use a different loop variable, `i` was already taken. This caused
missing items in the implementors list.
* Use `.getAttribute('href')` rather than `.href` to get the relative
URL which is what it needs to actually fix the links.
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 19, 2017

📌 Commit e48086c has been approved by GuillaumeGomez

@shepmaster shepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 19, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 19, 2017
…meGomez

rustdoc: Fix implementors list javascript

* Use a different loop variable, `i` was already taken. This caused
missing items in the implementors list.
* Use `.getAttribute('href')` rather than `.href` to get the relative
URL which is what it needs to actually fix the links.

More fallout from rust-lang#41307.

r? @GuillaumeGomez
bors added a commit that referenced this pull request May 19, 2017
@bors bors merged commit e48086c into rust-lang:master May 19, 2017
@ollie27 ollie27 deleted the rustdoc_js_impls branch May 20, 2017 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants