Update documentation for indexing/slicing methods #42236
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/libcollections/slice.rs
Outdated
| @@ -435,7 +441,6 @@ impl<T> [T] { | |||
| } | |||
|
|
|||
| /// Returns a raw pointer to the slice's buffer. | |||
| /// | |||
There was a problem hiding this comment.
Sausage fingers...
src/libcollections/str.rs
Outdated
| @@ -433,7 +433,11 @@ impl str { | |||
| } | |||
|
|
|||
| /// Creates a string slice from another string slice, bypassing safety | |||
| /// checks. | |||
| /// checks. This is generally not recommended, use with caution! | |||
There was a problem hiding this comment.
Please add an empty line before the new sentence.
src/libcollections/str.rs
Outdated
| @@ -476,7 +480,11 @@ impl str { | |||
| } | |||
|
|
|||
| /// Creates a string slice from another string slice, bypassing safety | |||
| /// checks. | |||
| /// checks. This is generally not recommended, use with caution! | |||
There was a problem hiding this comment.
Please add an empty line before the new sentence.
src/libcollections/slice.rs
Outdated
| @@ -393,7 +393,10 @@ impl<T> [T] { | |||
| } | |||
|
|
|||
| /// Returns a reference to an element or subslice, without doing bounds | |||
| /// checking. So use it very carefully! | |||
| /// checking. This is generally not recommended, use with caution! For | |||
There was a problem hiding this comment.
Please add an empty line before the new sentence.
src/libcollections/slice.rs
Outdated
| @@ -413,7 +416,10 @@ impl<T> [T] { | |||
| } | |||
|
|
|||
| /// Returns a mutable reference to an element or subslice, without doing | |||
| /// bounds checking. So use it very carefully! | |||
| /// bounds checking. This is generally not recommended, use with caution! | |||
There was a problem hiding this comment.
Please add an empty line before the new sentence.
|
All good, just a few nits. |
citizen428
force-pushed
the
docs/unchecked-indexing-slicing
branch
from
3d5ea15
to
a6d455d
Compare
|
@GuillaumeGomez Thanks for the feedback, just updated the PR. |
citizen428
force-pushed
the
docs/unchecked-indexing-slicing
branch
from
a6d455d
to
bbf1dc4
Compare
|
Thanks! @bors: r+ rollup |
|
📌 Commit bbf1dc4 has been approved by |
…slicing, r=GuillaumeGomez Update documentation for indexing/slicing methods See rust-lang#39911 r? @steveklabnik
…slicing, r=GuillaumeGomez Update documentation for indexing/slicing methods See rust-lang#39911 r? @steveklabnik
|
☔ The latest upstream changes (presumably #42245) made this pull request unmergeable. Please resolve the merge conflicts. |
See #39911
r? @steveklabnik