Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use T as the subpattern type of Box<T> #42730

Merged
merged 1 commit into from
Jun 18, 2017
Merged

Use T as the subpattern type of Box<T> #42730

merged 1 commit into from
Jun 18, 2017

Conversation

tirr-c
Copy link
Contributor

@tirr-c tirr-c commented Jun 18, 2017 •
edited
Loading

The subpattern type of boxes being nil does not make sense because of box patterns. They should have their inner type as the subpattern type.

Fixes #42679, which describes ICE caused by the bug.

@tirr-c
Use T as the subpattern type of Box<T>
abebe8a 
The subpattern type of boxes being nil does not make sense because of
box patterns. They should have their inner type as the subpattern type.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eddyb
Copy link
Member

eddyb commented Jun 18, 2017

@VBChunguk If you rephrase your PR description to have "#42679" right after the word "fixes", then GitHub will close it when this PR is merged.

@eddyb
Copy link
Member

eddyb commented Jun 18, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Jun 18, 2017

📌 Commit abebe8a has been approved by eddyb

@Mark-Simulacrum
Copy link
Member

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 18, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42730 - VBChunguk:boxed-wild-pattern, r=eddyb
27a3f73 
Use T as the subpattern type of Box<T>

The subpattern type of boxes being nil does not make sense because of box patterns. They should have their inner type as the subpattern type.

Fixes rust-lang#42679, which describes ICE caused by the bug.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 18, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 18, 2017
@frewsxcv
Rollup merge of rust-lang#42730 - VBChunguk:boxed-wild-pattern, r=eddyb
4b0f574 
Use T as the subpattern type of Box<T>

The subpattern type of boxes being nil does not make sense because of box patterns. They should have their inner type as the subpattern type.

Fixes rust-lang#42679, which describes ICE caused by the bug.
@frewsxcv frewsxcv mentioned this pull request Jun 18, 2017
Closed
bors added a commit that referenced this pull request Jun 18, 2017
@bors
Auto merge of #42738 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
247a018 
Rollup of 7 pull requests

- Successful merges: #42695, #42714, #42720, #42723, #42730, #42731, #42734
- Failed merges: #42722
@bors bors merged commit abebe8a into rust-lang:master Jun 18, 2017
@tirr-c tirr-c deleted the boxed-wild-pattern branch June 19, 2017 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tirr-c @rust-highfive @eddyb @bors @Mark-Simulacrum