mark calls in the unwind path as !noinline #42771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason noinline over cold was used? |
|
Either way, can always change later if there any benefits to do so. @bors r+ |
|
📌 Commit 485e799 has been approved by |
kennytm
reviewed
Jun 20, 2017
src/test/run-pass/issue-41696.rs
Outdated
| @@ -10,7 +10,6 @@ | |||
|
|
|||
| // this used to cause exponential code-size blowup during LLVM passes. | |||
| // ignore-test FIXME #41696 | |||
There was a problem hiding this comment.
Should this ignore-test comment be removed, or is the test still failing?
The unwind path is always cold, so that should not have bad performance implications. This avoids catastrophic exponential inlining, and also decreases the size of librustc.so by 1.5% (OTOH, the size of `libstd.so` increased by 0.5% for some reason). Fixes rust-lang#41696.
arielb1
force-pushed
the
no-inline-unwind
branch
from
485e799
to
0b93798
Compare
Indeed. @bors r=nagisa |
|
📌 Commit 0b93798 has been approved by |
Indeed. @bors r=nagisa |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 0b93798 has been approved by |
arielb1
added
the
S-waiting-on-bors
arielb1
force-pushed
the
no-inline-unwind
branch
from
74bcee6
to
0b93798
Compare
|
Had an accidental push @bors r=nagisa |
|
📌 Commit 0b93798 has been approved by |
bors
added a commit
that referenced
this pull request
Jun 21, 2017
mark calls in the unwind path as !noinline The unwind path is always cold, so that should not have bad performance implications. This avoids catastrophic exponential inlining, and also decreases the size of librustc.so by 1.5% (OTOH, the size of `libstd.so` increased by 0.5% for some reason). Fixes #41696. r? @nagisa
|
☀️ Test successful - status-appveyor, status-travis |
Closed
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 1, 2022
Mark drop calls in landing pads `cold` instead of `noinline` Now that deferred inlining has been disabled in LLVM (rust-lang#92110), this shouldn't cause catastrophic size blowup. I confirmed that the test cases from rust-lang#41696 (comment) still compile quickly (<1s) after this change. ~Although note that I wasn't able to reproduce the original issue using a recent rustc/llvm with deferred inlining enabled, so those tests may no longer be representative. I was also unable to create a modified test case that reproduced the original issue.~ (edit: I reproduced it on CI by accident--the first commit timed out on the LLVM 12 builder, because I forgot to make it conditional on LLVM version) r? `@nagisa` cc `@arielb1` (this effectively reverts rust-lang#42771 "mark calls in the unwind path as !noinline") cc `@RalfJung` (fixes rust-lang#46515) edit: also fixes rust-lang#87055
bjorn3
pushed a commit
to bjorn3/rust
that referenced
this pull request
Feb 1, 2022
Mark drop calls in landing pads `cold` instead of `noinline` Now that deferred inlining has been disabled in LLVM (rust-lang#92110), this shouldn't cause catastrophic size blowup. I confirmed that the test cases from rust-lang#41696 (comment) still compile quickly (<1s) after this change. ~Although note that I wasn't able to reproduce the original issue using a recent rustc/llvm with deferred inlining enabled, so those tests may no longer be representative. I was also unable to create a modified test case that reproduced the original issue.~ (edit: I reproduced it on CI by accident--the first commit timed out on the LLVM 12 builder, because I forgot to make it conditional on LLVM version) r? `@nagisa` cc `@arielb1` (this effectively reverts rust-lang#42771 "mark calls in the unwind path as !noinline") cc `@RalfJung` (fixes rust-lang#46515) edit: also fixes rust-lang#87055
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unwind path is always cold, so that should not have bad performance
implications. This avoids catastrophic exponential inlining, and also
decreases the size of librustc.so by 1.5% (OTOH, the size of
libstd.soincreased by 0.5% for some reason).
Fixes #41696.
r? @nagisa