Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an extra note to late_bound_lifetime_arguments error/lint #43343

Merged
merged 1 commit into from
Jul 22, 2017
Merged

Add an extra note to late_bound_lifetime_arguments error/lint #43343

merged 1 commit into from
Jul 22, 2017

Conversation

petrochenkov
Copy link
Contributor

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov petrochenkov mentioned this pull request Jul 19, 2017
Open
3 tasks
@petrochenkov
Copy link
Contributor Author

r? @estebank

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jul 20, 2017

📌 Commit 18d9701 has been approved by estebank

@alexcrichton alexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 20, 2017
@bors
Copy link
Contributor

bors commented Jul 21, 2017

⌛ Testing commit 18d9701 with merge 53cc5b773521da8bea78420b8eaffb4501f2637d...

@bors
Copy link
Contributor

bors commented Jul 21, 2017

💔 Test failed - status-travis

@petrochenkov
Copy link
Contributor Author

Looks like some infra issue, not sure spurious or not.
@bors retry

[00:06:07] ERROR: An error was encountered with the build.
[INFO ]  Performing some trivial sanity checks
[INFO ]  Build started 20170721.093532
[INFO ]  Building environment variables
[INFO ]  =================================================================
[INFO ]  Retrieving needed toolchain components' tarballs
[ERROR]  
[ERROR]  >>
[ERROR]  >>  Build failed in step 'Retrieving needed toolchain components' tarballs'
[ERROR]  >>        called in step '(top-level)'
[ERROR]  >>
[ERROR]  >>  Error happened in: do_isl_get[scripts/build/companion_libs/121-isl.sh@741]
[ERROR]  >>        called from: do_companion_libs_get[scripts/build/companion_libs.sh@15]
[ERROR]  >>        called from: main[scripts/crosstool-NG.sh@591]
[ERROR]  >>
[ERROR]  >>  For more info on this error, look at the file: 'build.log'
[ERROR]  >>  There is a list of known issues, some with workarounds, in:
[ERROR]  >>      '/usr/local/share/doc/crosstool-ng/crosstool-ng-1.22.0/B - Known issues.txt'
[ERROR]  
[ERROR]  (elapsed: 4:38.81)
[04:39] / make: *** [build] Error 1

@bors
Copy link
Contributor

bors commented Jul 21, 2017

⌛ Testing commit 18d9701 with merge 5be21773a9ab31d3c372f60c237e7b3707ee9104...

@SimonSapin
Copy link
Contributor

Got the same error in #43319

@bors
Copy link
Contributor

bors commented Jul 21, 2017

💔 Test failed - status-travis

@SimonSapin SimonSapin mentioned this pull request Jul 21, 2017
Merged
@aidanhs aidanhs mentioned this pull request Jul 21, 2017
Merged
@aidanhs
Copy link
Member

aidanhs commented Jul 21, 2017

@bors retry

(a current retried build appears to have got past the issue, so the cached dockerfile should be used from now on which will hopefully resolve the issue)

TimNN added a commit to TimNN/rust that referenced this pull request Jul 21, 2017
@TimNN
Rollup merge of rust-lang#43343 - petrochenkov:methlife3, r=estebank
fb8034b 
Add an extra note to `late_bound_lifetime_arguments` error/lint

Fixes rust-lang#42868 (comment)
@TimNN TimNN mentioned this pull request Jul 21, 2017
Closed
bors added a commit that referenced this pull request Jul 21, 2017
@bors
Auto merge of #43388 - TimNN:rollup, r=TimNN
bf51b85 
Rollup of 8 pull requests

- Successful merges: #43046, #43256, #43280, #43297, #43313, #43319, #43322, #43343
- Failed merges:
@bors
Copy link
Contributor

bors commented Jul 21, 2017

⌛ Testing commit 18d9701 with merge 8fed6814e1668cf8d4cb3c93ed54206b7c98734b...

@bors
Copy link
Contributor

bors commented Jul 21, 2017

💔 Test failed - status-appveyor

@estebank
Copy link
Contributor

That's an odd error:

failures:
---- [run-make] run-make\issue-26092 stdout ----
	
error: make failed
status: exit code: 2
command: "make"
stdout:
------------------------------------------
PATH="/c/projects/rust/build/x86_64-pc-windows-gnu/test/run-make/issue-26092.stage2-x86_64-pc-windows-gnu:C:\projects\rust\build\x86_64-pc-windows-gnu\stage2\bin:/c/projects/rust/build/x86_64-pc-windows-gnu/stage2-tools/x86_64-pc-windows-gnu/release/deps:/c/projects/rust/build/x86_64-pc-windows-gnu/stage2/lib/rustlib/x86_64-pc-windows-gnu/lib:/c/Program Files (x86)/Inno Setup 5:/c/Python27:/c/projects/rust/mingw64/bin:/usr/bin:/c/Perl/site/bin:/c/Perl/bin:/c/Windows/system32:/c/Windows:/c/Windows/System32/Wbem:/c/Windows/System32/WindowsPowerShell/v1.0:/c/Program Files/7-Zip:/c/Program Files/Microsoft/Web Platform Installer:/c/Tools/GitVersion:/c/Tools/PsTools:/c/Program Files/Git LFS:/c/Program Files (x86)/Subversion/bin:/c/Program Files/Microsoft SQL Server/120/Tools/Binn:/c/Program Files/Microsoft SQL Server/Client SDK/ODBC/110/Tools/Binn:/c/Program Files (x86)/Microsoft SQL Server/120/Tools/Binn:/c/Program Files/Microsoft SQL Server/120/DTS/Binn:/c/Program Files (x86)/Microsoft SQL Server/120/Tools/Binn/ManagementStudio:/c/Tools/WebDriver:/c/Program Files (x86)/Microsoft SDKs/TypeScript/1.4:/c/Program Files (x86)/Microsoft Visual Studio 12.0/Common7/IDE/PrivateAssemblies:/c/Program Files (x86)/Microsoft SDKs/Azure/CLI/wbin:/c/Ruby193/bin:/c/Tools/NUnit/bin:/c/Tools/xUnit:/c/Tools/MSpec:/c/Tools/Coverity/bin:/c/Program Files (x86)/CMake/bin:/c/go/bin:/c/Program Files/Java/jdk1.8.0/bin:/c/Python27:/c/Program Files/nodejs:/c/Program Files (x86)/iojs:/c/Program Files/iojs:/c/Users/appveyor/AppData/Roaming/npm:/c/Program Files/Microsoft SQL Server/130/Tools/Binn:/c/Program Files (x86)/MSBuild/14.0/Bin:/c/Tools/NuGet:/c/Program Files (x86)/Microsoft Visual Studio 14.0/Common7/IDE/CommonExtensions/Microsoft/TestWindow:/c/Program Files/Microsoft DNX/Dnvm:/c/Program Files/Microsoft SQL Server/Client SDK/ODBC/130/Tools/Binn:/c/Program Files (x86)/Microsoft SQL Server/130/Tools/Binn:/c/Program Files (x86)/Microsoft SQL Server/130/DTS/Binn:/c/Program Files/Microsoft SQL Server/130/DTS/Binn:/c/Program Files (x86)/Microsoft SQL Server/110/DTS/Binn:/c/Program Files (x86)/Microsoft SQL Server/120/DTS/Binn:/c/Program Files (x86)/Apache/Maven/bin:/c/Python27/Scripts:/c/Tools/NUnit3:/c/Program Files/Mercurial:/c/Program Files/LLVM/bin:/c/Program Files/dotnet:/c/Program Files/erl8.3/bin:/c/Tools/curl/bin:/c/Program Files/Amazon/AWSCLI:/c/Program Files/Git/cmd:/c/Program Files/Git/usr/bin:/c/Program Files (x86)/Microsoft SQL Server/140/DTS/Binn:/c/Program Files (x86)/Microsoft Visual Studio 14.0/Common7/IDE/Extensions/Microsoft/SQLDB/DAC/140:/c/ProgramData/chocolatey/bin:/c/Program Files (x86)/Yarn/bin:/c/Program Files/Microsoft Service Fabric/bin/Fabric/Fabric.Code:/c/Program Files/Microsoft SDKs/Service Fabric/Tools/ServiceFabricLocalClusterManager:/c/Program Files (x86)/nodejs:/c/Users/appveyor/AppData/Local/Yarn/bin:/c/Users/appveyor/AppData/Roaming/npm:/c/Program Files/AppVeyor/BuildAgent:/c/projects/rust:/c/projects/rust/handle" 'C:\projects\rust\build\x86_64-pc-windows-gnu\stage2\bin\rustc.exe' --out-dir /c/projects/rust/build/x86_64-pc-windows-gnu/test/run-make/issue-26092.stage2-x86_64-pc-windows-gnu -L /c/projects/rust/build/x86_64-pc-windows-gnu/test/run-make/issue-26092.stage2-x86_64-pc-windows-gnu  -o "" blank.rs 2>&1 | \
		grep -i 'No such file or directory'
------------------------------------------
stderr:
------------------------------------------
make: *** [Makefile:4: all] Error 1
------------------------------------------
thread '[run-make] run-make\issue-26092' panicked at 'explicit panic', src\tools\compiletest\src\runtest.rs:2479:8
note: Run with `RUST_BACKTRACE=1` for a backtrace.
failures:
    [run-make] run-make\issue-26092
test result: FAILED. 155 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
thread 'main' panicked at 'Some tests failed', src\tools\compiletest\src\main.rs:323:21

@petrochenkov
Copy link
Contributor Author

I've seen it before and it was transient
@bors retry

@alexcrichton
Copy link
Member

@petrochenkov out of curiosity, do you know if there's an issue filed for that spurious failure?

@petrochenkov
Copy link
Contributor Author

Looks like no issue was filed for it.

It also looks like a regression, it never happened previously but showed up several times recently in this PR and in #43224, #43179 and #43115.

@alexcrichton
Copy link
Member

Thanks! I've filed an issue for that.

@bors
Copy link
Contributor

bors commented Jul 22, 2017

⌛ Testing commit 18d9701 with merge 066a0ae...

bors added a commit that referenced this pull request Jul 22, 2017
@bors
Auto merge of #43343 - petrochenkov:methlife3, r=estebank
066a0ae 
Add an extra note to `late_bound_lifetime_arguments` error/lint

Fixes #42868 (comment)
@bors
Copy link
Contributor

bors commented Jul 22, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: estebank
Pushing 066a0ae to master...

@bors bors merged commit 18d9701 into rust-lang:master Jul 22, 2017
@petrochenkov petrochenkov deleted the methlife3 branch August 26, 2017 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@petrochenkov @rust-highfive @estebank @bors @SimonSapin @aidanhs @alexcrichton @pnkfelix