Rustbuild regression fixes

[Mark-Simulacrum]

I believe this will fix #43427.

This PR also avoids running pretty tests by-default.

r? @alexcrichton

[Mark-Simulacrum]

@bors p=100 (once this is reviewed)

[alexcrichton]

@bors: r+

[bors]

📌 Commit 003bbfc has been approved by alexcrichton

[bors]

⌛ Testing commit 003bbfceb6ee9ea90eb7725d7cdcff6344402000 with merge d05e8853f3f061b1a9a08f317ecbb632b10d8cc9...

[Mark-Simulacrum]

@bors r- retry

[Mark-Simulacrum]

@bors r+ p=100

[bors]

📌 Commit bcc610a has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit bcc610a76f15a21dbcac065f1e6cdf5581141842 with merge 6e5f4acdf4346fce513f96d080e6f61ca7e79ae5...

[bors]

💔 Test failed - status-travis

[kennytm]

Fuchsia failed to build LLVM at stage1 (why?). Legit.

[00:52:07] thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "target `x86_64-unknown-fuchsia` is not configured as a host, only as a target"', /checkout/src/libcore/result.rs:860

[Mark-Simulacrum]

@bors r=alexcrichton

I believe the last commit makes dist and install equivalent to what the old build system ran, which should hopefully resolve our issues.

[bors]

📌 Commit 9bad3dc has been approved by alexcrichton

[kennytm]

@Mark-Simulacrum The PR CI failed to build bootstrap.

[00:01:17]    Compiling bootstrap v0.0.0 (file:///checkout/src/bootstrap)
[00:01:18] error[E0560]: struct `dist::DebuggerScripts` has no field named `target`
[00:01:18]    --> /checkout/src/bootstrap/check.rs:538:17
[00:01:18]     |
[00:01:18] 538 |                 target: target
[00:01:18]     |                 ^^^^^^^ field does not exist - did you mean `host`?
[00:01:18] 
[00:01:19] error[E0560]: struct `dist::DebuggerScripts` has no field named `target`
[00:01:19]    --> /checkout/src/bootstrap/dist.rs:435:17
[00:01:19]     |
[00:01:19] 435 |                 target: host,
[00:01:19]     |                 ^^^^^^^ field does not exist - did you mean `host`?
[00:01:19] 
[00:01:19] error[E0560]: struct `dist::Extended` has no field named `compiler`
[00:01:19]     --> /checkout/src/bootstrap/dist.rs:1103:13
[00:01:19]      |
[00:01:19] 1103 |             compiler: run.builder.top_stage,
[00:01:19]      |             ^^^^^^^^^ field does not exist - did you mean `stage`?

[bors]

⌛ Testing commit 9bad3dcb9671b6dd597d3d9e1ae529cc2775e680 with merge 3c4fc0f3f66785c410b8ee3245aa26b23d50ef38...

[bors]

💔 Test failed - status-appveyor

[Mark-Simulacrum]

@bors r=alexcrichton

[bors]

📌 Commit fef9b48 has been approved by alexcrichton

[bors]

⌛ Testing commit fef9b48 with merge 2ad68c47023a625d693c69b88e1d9f0a476bf48b...

[bors]

💔 Test failed - status-travis

[Mark-Simulacrum]

@bors retry

• Spurious failure in RLS tests #43453

[01:21:53] 
[01:21:53] failures:
[01:21:53] 
[01:21:53] ---- test::test_borrow_error stdout ----
[01:21:53] 	thread 'test::test_borrow_error' panicked at 'Hit timeout', /checkout/src/tools/rls/src/test/harness.rs:142:12
[01:21:53] 
[01:21:53] 
[01:21:53] failures:
[01:21:53]     test::test_borrow_error

[bors]

⌛ Testing commit fef9b48 with merge b80e946...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing b80e946 to master...