rustdoc: Don't add external impls to implementors js #43736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
ollie27
force-pushed
the
rustdoc_impls_js
branch
from
58d5d75
to
54f5297
Compare
Otherwise impls from not documented crates appear.
ollie27
force-pushed
the
rustdoc_impls_js
branch
from
54f5297
to
c62a8c5
Compare
aidanhs
added
the
S-waiting-on-review
|
@bors r+ Thanks! This was a rabbit-hole i almost went down myself when working on something else. |
|
📌 Commit c62a8c5 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 12, 2017
rustdoc: Don't add external impls to implementors js Otherwise impls from not documented crates appear. Fixes #43701
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise impls from not documented crates appear.
Fixes #43701