Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include 'let' keyword to the span for ast::Local #43822

Merged
merged 1 commit into from
Aug 13, 2017
Merged

Include 'let' keyword to the span for ast::Local #43822

merged 1 commit into from
Aug 13, 2017

Conversation

topecongiro
Copy link
Contributor

@topecongiro topecongiro commented Aug 12, 2017 •
edited
Loading

Currently the span for ast::Local does not include the let keyword. This PR fixes it.

@petrochenkov
Copy link
Contributor

Thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 12, 2017

📌 Commit 64503b6 has been approved by petrochenkov

@alexcrichton alexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 12, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 13, 2017
@GuillaumeGomez
Rollup merge of rust-lang#43822 - topecongiro:missing-span-let, r=pet…
31916ac 
…rochenkov

Include 'let' keyword to the span for ast::Local

Currently the span for `ast::Local` does not the include the `let` keyword. This PR fixes it.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Aug 13, 2017
Merged
bors added a commit that referenced this pull request Aug 13, 2017
@bors
Auto merge of #43839 - GuillaumeGomez:rollup, r=GuillaumeGomez
a80a873 
Rollup of 8 pull requests

- Successful merges: #43782, #43803, #43814, #43819, #43821, #43822, #43824, #43833
- Failed merges:
@bors bors merged commit 64503b6 into rust-lang:master Aug 13, 2017
@topecongiro topecongiro deleted the missing-span-let branch August 13, 2017 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@topecongiro @petrochenkov @bors @alexcrichton