Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustbook: remove dead test functions #44313

Merged
merged 1 commit into from
Sep 7, 2017
Merged

rustbook: remove dead test functions #44313

merged 1 commit into from
Sep 7, 2017

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 4, 2017

There is no "test" subcommand added to the clap::App, so this is all dead code.

Cc @steveklabnik -- your commit introducing this stated the intention of having both commands, but it seems nobody has missed the test command since February.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Sep 5, 2017

📌 Commit adbb820 has been approved by nikomatsakis

@nikomatsakis
Copy link
Contributor

@steveklabnik feel free to tell stop bors if you disagree; deleting dead code almost always seems good to me, though, since it's "still around" in git...

@steveklabnik
Copy link
Member

I originally added it because I figured we'd need to test the book; if it's being tested some other way, then yeah, seems fine!

@RalfJung
Copy link
Member Author

RalfJung commented Sep 5, 2017

if it is tested at all (which I do not know), then it is tested another way.

@arielb1 arielb1 added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 5, 2017
@frewsxcv
Copy link
Member

frewsxcv commented Sep 6, 2017

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 7, 2017
rustbook: remove dead test functions

There is no "test" subcommand added to the `clap::App`, so this is all dead code.

Cc @steveklabnik -- your [commit](RalfJung@a076961) introducing this stated the intention of having both commands, but it seems nobody has missed the `test` command since February.
bors added a commit that referenced this pull request Sep 7, 2017
@bors bors merged commit adbb820 into rust-lang:master Sep 7, 2017
@RalfJung RalfJung deleted the book branch July 10, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants