Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of Travis's conditional jobs. #44631

Merged
merged 1 commit into from
Sep 17, 2017

Conversation

kennytm
Copy link
Member

@kennytm kennytm commented Sep 16, 2017

Conditional jobs: https://docs.travis-ci.com/user/conditional-builds-stages-jobs/#Conditional-Jobs.

Jobs not matching the condition will not be scheduled at all. This allows us to get rid of $ALLOW_PR/$ALLOW_TRY/$SKIP_BUILD in .travis.yml, and perfectly prevent spurious PR failures due to flaky macOS machines.

@kennytm
Copy link
Member Author

kennytm commented Sep 16, 2017

@bors try

Let me verify if the try build works before merging.

@bors
Copy link
Contributor

bors commented Sep 16, 2017

⌛ Trying commit 9f76354 with merge f0b4249...

bors added a commit that referenced this pull request Sep 16, 2017
[DO NOT MERGE] Make use of Travis's conditional jobs.

Conditional jobs: https://docs.travis-ci.com/user/conditional-builds-stages-jobs/#Conditional-Jobs.

Jobs not matching the condition will not be scheduled at all. This allows us to get rid of `$ALLOW_PR`/`$ALLOW_TRY`/`$SKIP_BUILD` in `.travis.yml`, and perfectly prevent spurious PR failures due to flaky macOS machines.
@kennytm kennytm changed the title [DO NOT MERGE] Make use of Travis's conditional jobs. Make use of Travis's conditional jobs. Sep 16, 2017
@kennytm
Copy link
Member Author

kennytm commented Sep 16, 2017

OK try build works (?). The remaining thing is to ensure all 41 jobs are running during the actual test.


EDIT: Not sure if relevant, but the try build failed to download the cache archive, causing 45 minutes spent on building docker. Maybe just due to removing the ALLOW_TRY=1/ALLOW_PR=1 from env.

attempting to download cache archive
fetching try/cache-linux-trusty-70f9407258c60900855a3084c00fd20c656cf873dba281d668f25c4bced6e8fc.tgz
fetching master/cache-linux-trusty-70f9407258c60900855a3084c00fd20c656cf873dba281d668f25c4bced6e8fc.tgz
could not download cache

@Mark-Simulacrum
Copy link
Member

r? @alexcrichton

r=me, but I want to run this past you as well.

cc @rust-lang/infra as well.

@bors
Copy link
Contributor

bors commented Sep 16, 2017

☀️ Test successful - status-travis
State: approved= try=True

@TimNN
Copy link
Contributor

TimNN commented Sep 16, 2017

@kennytm:

EDIT: Not sure if relevant, but the try build failed to download the cache archive. Maybe just due to removing the ALLOW_TRY=1/ALLOW_PR=1 from env.

That seems to be the case, see https://docs.travis-ci.com/user/caching/#Caches-and-build-matrices

@alexcrichton
Copy link
Member

@bors: r+

Nice find!

@bors
Copy link
Contributor

bors commented Sep 16, 2017

📌 Commit 9f76354 has been approved by alexcrichton

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 17, 2017
…alexcrichton

Make use of Travis's conditional jobs.

Conditional jobs: https://docs.travis-ci.com/user/conditional-builds-stages-jobs/#Conditional-Jobs.

Jobs not matching the condition will not be scheduled at all. This allows us to get rid of `$ALLOW_PR`/`$ALLOW_TRY`/`$SKIP_BUILD` in `.travis.yml`, and perfectly prevent spurious PR failures due to flaky macOS machines.
bors added a commit that referenced this pull request Sep 17, 2017
@bors bors merged commit 9f76354 into rust-lang:master Sep 17, 2017
@kennytm kennytm deleted the travis-conditional-jobs branch October 7, 2017 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants