Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comments referring to old check_method_self_type #45099

Merged
merged 1 commit into from
Oct 10, 2017
Merged

Update comments referring to old check_method_self_type #45099

merged 1 commit into from
Oct 10, 2017

Conversation

mikeyhew
Copy link
Contributor

@mikeyhew mikeyhew commented Oct 8, 2017 •
edited
Loading

I was browsing the code base, trying to figure out how #44874 could be implemented, and noticed some comments that were out of date and a bit misleading (check_method_self_type has since been renamed to check_method_receiver). Thought it would be an easy first contribution to Rust!

@mikeyhew
update comments referring to old check_method_self_type
6f4e942 
- function has been renamed to check_method_receiver
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@carols10cents
Copy link
Member

Thanks for the PR! We’ll periodically check in on it to make sure that @arielb1 or someone else from the team reviews it soon.

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2017
@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 9, 2017

📌 Commit 6f4e942 has been approved by nikomatsakis

@kennytm kennytm mentioned this pull request Oct 10, 2017
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Oct 10, 2017
@kennytm
Rollup merge of rust-lang#45099 - mikeyhew:fix-astconv-self-type-comm…
2f4dd15 
…ents, r=nikomatsakis

Update comments referring to old check_method_self_type

I was browsing the code base, trying to figure out how rust-lang#44874 could be implemented, and noticed some comments that were out of date and a bit misleading (`check_method_self_type` has since been renamed to `check_method_receiver`). Thought it would be an easy first contribution to Rust!
bors added a commit that referenced this pull request Oct 10, 2017
@bors
Auto merge of #45169 - kennytm:rollup, r=kennytm
d6d711d 
Rollup of 9 pull requests

- Successful merges: #44775, #45089, #45095, #45099, #45101, #45108, #45116, #45135, #45146
- Failed merges:
@bors bors merged commit 6f4e942 into rust-lang:master Oct 10, 2017
@mikeyhew mikeyhew deleted the fix-astconv-self-type-comments branch October 10, 2017 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikeyhew @rust-highfive @carols10cents @nikomatsakis @bors @arielb1