Add several lints into `unused` lint group #45424

petrochenkov · 2017-10-20T23:17:06Z

Also a couple of obsolete (not reported) lints are removed.

petrochenkov · 2017-10-20T23:18:51Z

src/librustc_passes/consts.rs

@@ -140,8 +140,7 @@ impl<'a, 'gcx> CheckCrateVisitor<'a, 'gcx> {
                    self.tcx.lint_node(CONST_ERR,
                                       expr.id,
                                       expr.span,
-                                       &format!("constant evaluation error: {}. This will \
-                                                 become a HARD ERROR in the future",
+                                       &format!("constant evaluation error: {}",


@oli-obk
I initially wanted to move const_err into the future_incompatible group based on this comment, but it looks like this comment was actually outdated and this lint is not going to be an error?

Yea. These are essentially bugs

petrochenkov · 2017-10-20T23:33:07Z

I've also audited the remaining ungrouped lints.
In principle new lint groups can be created for them, but it looks like fine-grained lint grouping didn't find its use even in clippy, so I didn't do anything. cc clippy people just in case @mcarton @llogiq

Unused++.
These can also be quite reasonably added into the unused group, but less obviously than those I added into it in this PR.

STABLE_FEATURES
RENAMED_AND_REMOVED_LINTS
UNKNOWN_LINTS
UNUSED_COMPARISONS

Bad style++.
Probably can be added into the bad_style group, but it currently consists only of casing-related lints.

NON_SHORTHAND_FIELD_PATTERNS
WHILE_TRUE

Future compatibility++.
Errors that are reported as lints for some reasons unknown to me.
See the question in #45424 (comment) as well.

CONST_ERR // ?
UNKNOWN_CRATE_TYPES // Deny-by-default
NO_MANGLE_CONST_ITEMS // Deny-by-default
NO_MANGLE_GENERIC_ITEMS

Restrictions.
Something generally reasonable that can be prohibited if necessary.

BOX_POINTERS // Allow-by-default
UNSAFE_CODE // Allow-by-default
UNSTABLE_FEATURES // Allow-by-default
MISSING_DOCS // Allow-by-default
MISSING_COPY_IMPLEMENTATIONS // Allow-by-default
MISSING_DEBUG_IMPLEMENTATIONS // Allow-by-default

Pedantic.
Something not bad enough to always report/fix.

UNUSED_RESULTS // Allow-by-default
UNUSED_IMPORT_BRACES // Allow-by-default
UNUSED_QUALIFICATIONS // Allow-by-default
TRIVIAL_CASTS // Allow-by-default
TRIVIAL_NUMERIC_CASTS // Allow-by-default
VARIANT_SIZE_DIFFERENCES // Allow-by-default
UNIONS_WITH_DROP_FIELDS

Obvious mistakes.
Prevent foot shooting, some can become hard errors in principle.

OVERFLOWING_LITERALS
EXCEEDING_BITSHIFTS // Deny-by-default
UNCONDITIONAL_RECURSION
MUTABLE_TRANSMUTES // Deny-by-default
IMPROPER_CTYPES
PLUGIN_AS_LIBRARY
PRIVATE_NO_MANGLE_FNS
PRIVATE_NO_MANGLE_STATICS

General purpose lints.

WARNINGS
DEPRECATED

oli-obk

The lint store has a function register_removed

oli-obk · 2017-10-21T15:10:02Z

src/librustc_lint/builtin.rs

@@ -621,12 +621,6 @@ impl EarlyLintPass for AnonymousParameters {
    }
 }

-declare_lint! {
-    DEPRECATED_ATTR,


Just removing these lints will cause users who mention them in allow/warn/deny statements to produce warnings about unknown lints. Does rustc have a removed lint list like clippy does?

Yes, there's a list of removed lints, I'll add these lints into it.

oli-obk · 2017-10-21T15:14:55Z

I would like fine grained grouping. I think we have an open issue in clippy. People often complain that they are overwhelmed by the style lints, when they want to get to the bug lints first

bors · 2017-10-28T18:49:38Z

☔ The latest upstream changes (presumably #45489) made this pull request unmergeable. Please resolve the merge conflicts.

petrochenkov · 2017-10-28T23:15:13Z

Rebased and updated with a fix for #45424 (comment)

oli-obk · 2017-10-29T11:57:26Z

Lgtm now. Do we have an issue to discuss the fine grained lint groups and not clear cut "unused"-lints? #45424 (comment) as an issue would be good I think

@bors r+

bors · 2017-10-29T11:57:27Z

@oli-obk: 🔑 Insufficient privileges: Not in reviewers

petrochenkov · 2017-10-29T12:47:20Z

@bors r=oli-obk

bors · 2017-10-29T12:47:21Z

📌 Commit 0b7a8b5 has been approved by oli-obk

petrochenkov · 2017-10-29T12:52:38Z

@oli-obk

Do we have an issue to discuss the fine grained lint groups and not clear cut "unused"-lints?

I've created #45615 for this.

bors · 2017-10-29T13:29:51Z

⌛ Testing commit 0b7a8b5b146c002177ade20be0a29a2d34cafed3 with merge 518ec2985dd8476aabaa3966564073bc7a393464...

bors · 2017-10-29T15:22:10Z

💔 Test failed - status-travis

kennytm · 2017-10-29T15:41:46Z

@bors retry #43283 (arm-android test_process_output_fail_to_start 30min no output)

[01:10:10] test process::tests::test_process_output_fail_to_start has been running for over 60 seconds


No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

bors · 2017-10-29T18:04:32Z

⌛ Testing commit 0b7a8b5b146c002177ade20be0a29a2d34cafed3 with merge 5b370c494c9f0039676c7b72c21206d960155e95...

bors · 2017-10-29T18:44:12Z

💔 Test failed - status-travis

Remove a couple of obsolete lints

kennytm · 2017-10-29T19:16:00Z

The use of :vis have broken clippy. But should the feature gate error be emitted when compiling clippy, as a user of the macro instead of the provider? cc #41022 @durka.

[00:34:29]    Compiling clippy_lints v0.0.166 (file:///checkout/src/tools/clippy/clippy_lints)
[00:34:29] error: :vis fragment specifier is experimental and subject to change (see issue #41022)
[00:34:29]  --> <declare_lint macros>:1:3
[00:34:29]   |
[00:34:29] 1 | ( $ vis : vis $ NAME : ident , $ Level : ident , $ desc : expr ) => (
[00:34:29]   |   ^^^^^^^^^^^
[00:34:29]   |
[00:34:29]   = help: add #![feature(macro_vis_matcher)] to the crate attributes to enable
[00:34:29] 
[00:34:29] error: :vis fragment specifier is experimental and subject to change (see issue #41022)
[00:34:29]  --> <declare_lint macros>:1:3
[00:34:29]   |
[00:34:29] 1 | ( $ vis : vis $ NAME : ident , $ Level : ident , $ desc : expr ) => (
[00:34:29]   |   ^^^^^^^^^^^
[00:34:29]   |
[00:34:29]   = help: add #![feature(macro_vis_matcher)] to the crate attributes to enable
[00:34:29] 
[00:34:30] error: aborting due to previous error
[00:34:30] 
[00:34:30] error: Could not compile `clippy_lints`.
[00:34:30] warning: build failed, waiting for other jobs to finish...
[00:34:30] error: aborting due to previous error
[00:34:30] 
[00:34:30] error: Could not compile `clippy_lints`.
[00:34:30] warning: build failed, waiting for other jobs to finish...
[00:34:41] error: build failed

petrochenkov · 2017-10-29T19:19:25Z

@bors r=oli-obk

bors · 2017-10-29T19:19:26Z

📌 Commit bf0cdb5 has been approved by oli-obk

durka · 2017-10-29T19:38:41Z

Hmm. Ideally the writer of the macro should need the feature gate, not the user. But AFAIK pretty much all checking of macros is left until the last possible second. For example the current version of error_chain has an undefined capture and nobody noticed until yesterday (and only because they wrote a stricter compiler).

durka · 2017-10-29T19:39:42Z

Let's just stabilize :vis and remove the issue 😛

bors · 2017-10-29T23:59:14Z

⌛ Testing commit bf0cdb5 with merge dae6868...

@oli-obk

Add several lints into `unused` lint group Also a couple of obsolete (not reported) lints are removed. r? @oli-obk

bors · 2017-10-30T02:33:47Z

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing dae6868 to master...

Manishearth · 2017-10-31T01:18:41Z

Uh, please at least try to fix tools that break (even if you mark it as broken in the interim).

In this case for some reason #![feature(macro_vis_matcher)] does not fix the problem in clippy; it continues to give the same error despite being allowed already.

Manishearth · 2017-10-31T01:19:19Z

Oh, nvm, I made a mistake. Sorry.

petrochenkov commented Oct 20, 2017

View reviewed changes

kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2017

oli-obk requested changes Oct 21, 2017

View reviewed changes

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2017

petrochenkov force-pushed the grlint branch from b1fac94 to 0b7a8b5 Compare October 28, 2017 23:14

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 29, 2017

petrochenkov mentioned this pull request Oct 29, 2017

Consider more fine grained grouping for built-in lints #45615

Open

Add several lints into unused lint group

bf0cdb5

Remove a couple of obsolete lints

petrochenkov force-pushed the grlint branch from 0b7a8b5 to bf0cdb5 Compare October 29, 2017 19:14

bors added a commit that referenced this pull request Oct 29, 2017

Auto merge of #45424 - petrochenkov:grlint, r=oli-obk

dae6868

Add several lints into `unused` lint group Also a couple of obsolete (not reported) lints are removed. r? @oli-obk

bors merged commit bf0cdb5 into rust-lang:master Oct 30, 2017

petrochenkov deleted the grlint branch June 5, 2019 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add several lints into `unused` lint group #45424

Add several lints into `unused` lint group #45424

petrochenkov commented Oct 20, 2017

petrochenkov Oct 20, 2017

oli-obk Oct 21, 2017 •

edited

Loading

petrochenkov commented Oct 20, 2017 •

edited

Loading

oli-obk left a comment

oli-obk Oct 21, 2017

petrochenkov Oct 21, 2017 •

edited

Loading

oli-obk commented Oct 21, 2017

bors commented Oct 28, 2017

petrochenkov commented Oct 28, 2017

oli-obk commented Oct 29, 2017

bors commented Oct 29, 2017

petrochenkov commented Oct 29, 2017

bors commented Oct 29, 2017

petrochenkov commented Oct 29, 2017

bors commented Oct 29, 2017

bors commented Oct 29, 2017

kennytm commented Oct 29, 2017

bors commented Oct 29, 2017

bors commented Oct 29, 2017

kennytm commented Oct 29, 2017

petrochenkov commented Oct 29, 2017

bors commented Oct 29, 2017

durka commented Oct 29, 2017 •

edited

Loading

durka commented Oct 29, 2017

bors commented Oct 29, 2017

bors commented Oct 30, 2017

Manishearth commented Oct 31, 2017

Manishearth commented Oct 31, 2017

Add several lints into unused lint group #45424

Add several lints into unused lint group #45424

Conversation

petrochenkov commented Oct 20, 2017

petrochenkov Oct 20, 2017

Choose a reason for hiding this comment

oli-obk Oct 21, 2017 • edited Loading

Choose a reason for hiding this comment

petrochenkov commented Oct 20, 2017 • edited Loading

oli-obk left a comment

Choose a reason for hiding this comment

oli-obk Oct 21, 2017

Choose a reason for hiding this comment

petrochenkov Oct 21, 2017 • edited Loading

Choose a reason for hiding this comment

oli-obk commented Oct 21, 2017

bors commented Oct 28, 2017

petrochenkov commented Oct 28, 2017

oli-obk commented Oct 29, 2017

bors commented Oct 29, 2017

petrochenkov commented Oct 29, 2017

bors commented Oct 29, 2017

petrochenkov commented Oct 29, 2017

bors commented Oct 29, 2017

bors commented Oct 29, 2017

kennytm commented Oct 29, 2017

bors commented Oct 29, 2017

bors commented Oct 29, 2017

kennytm commented Oct 29, 2017

petrochenkov commented Oct 29, 2017

bors commented Oct 29, 2017

durka commented Oct 29, 2017 • edited Loading

durka commented Oct 29, 2017

bors commented Oct 29, 2017

bors commented Oct 30, 2017

Manishearth commented Oct 31, 2017

Manishearth commented Oct 31, 2017

Add several lints into `unused` lint group #45424

Add several lints into `unused` lint group #45424

oli-obk Oct 21, 2017 •

edited

Loading

petrochenkov commented Oct 20, 2017 •

edited

Loading

petrochenkov Oct 21, 2017 •

edited

Loading

durka commented Oct 29, 2017 •

edited

Loading