Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various refactorings towards universe-based regions #45657

Closed
wants to merge 16 commits into from
Closed

Various refactorings towards universe-based regions #45657

wants to merge 16 commits into from

Commits on Nov 7, 2017

  1. introduce Universe struct

    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    9ae5db2 View commit details
    Browse the repository at this point in the history

  2. add some comments to Obligation

    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    e88898f View commit details
    Browse the repository at this point in the history

  3. introduce UniverseIndex into ParamEnv 

    Always using root environment for now.
    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    1da0b70 View commit details
    Browse the repository at this point in the history

  4. use {} for Known variant just for more parity

    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    55f33ba View commit details
    Browse the repository at this point in the history

  5. make Default Copy and Clone

    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    c5eb255 View commit details
    Browse the repository at this point in the history

  6. kill custom type inference defaults (these don't really work anyway)

    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    5c69168 View commit details
    Browse the repository at this point in the history

  7. kill supporting code from type-variable defaults 

    This was all unused anyway.
    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    3251227 View commit details
    Browse the repository at this point in the history

  8. obtain UnificationTable and snapshot_vec from ena instead 

    The ena version has an improved interface. I suspect
`librustc_data_structures` should start migrating out to crates.io in
general.
    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    744f102 View commit details
    Browse the repository at this point in the history

  9. store type values in the unification table directly

    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    2b7f276 View commit details
    Browse the repository at this point in the history

  10. correct subtle bug in the type variable code

    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    66b961b View commit details
    Browse the repository at this point in the history

  11. have probe() return TypeVariableValue

    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    7148ff7 View commit details
    Browse the repository at this point in the history

  12. remove unnecessary clause propagating divergence 

    This should not be needed: the new variable will be related to the old
ones, so if they are constrained, so is the new variable; if they are
not, and hence default to diverging, so will the new variable.
    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    64918a2 View commit details
    Browse the repository at this point in the history

  13. add universes to type inference variables

    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    de2dcd6 View commit details
    Browse the repository at this point in the history

  14. change skolemizations to use universe index

    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    12a2305 View commit details
    Browse the repository at this point in the history

  15. fix tidy error

    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    3cee5c2 View commit details
    Browse the repository at this point in the history

  16. fix tests in librustc_driver

    @nikomatsakis
    nikomatsakis committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    edff811 View commit details
    Browse the repository at this point in the history