Updated RELEASES.md for 1.23.0 #46327

XAMPPRocky · 2017-11-28T12:04:48Z

rust-highfive · 2017-11-28T12:04:59Z

(rust_highfive has picked a reviewer for you, use r? to override)

steveklabnik · 2017-11-28T13:24:43Z

RELEASES.md

+
+Misc
+----
+- [Releases now ship with the Cargo book documentation.][45692]


This might have to get yanked if #46195 isn't resolved

kennytm · 2017-11-28T13:42:20Z

RELEASES.md

+  small files reduce the number of syscalls.
+
+Stabilized APIs
+---------------


APIs marked as since = "1.23":

impl FromIterator<()> for () (impl FromIterator<()> for () #45379)

#45990 didn't make it into 1.23.0.

@ollie27 Thanks.

kennytm · 2017-11-28T13:46:26Z

RELEASES.md

+  wide characters.][45711]
+- [rustc now uses subtyping on the left hand side of binary operations.][45435]
+  Which should fix some confusing errors in some operations.
+- [Bumped the minimum LLVM to 3.9][45326]


This may better be a compatibility note?

kennytm · 2017-11-28T13:53:04Z

RELEASES.md

+- [Upgraded Android SDK to 27, and NDK to r15c.][45580] This drops support for
+  Android 9, the minimum supported version is Android 14.
+- [Refactored type memory layouts and ABIs.][45225] This reduce code generated
+  for a lot of types.


#45225 should also be part of the Compiler section. I don't know about "code generated", as the most visible effect of #45225 is the reduced type size (e.g. size of Option<bool> is now 1 byte instead of 2 bytes; or more realistically, std::io::Result<()> is now 16 bytes long instead of 24 bytes).

hanna-kruppe · 2017-11-28T17:08:29Z

RELEASES.md

+Compiler
+--------
+- [Enabled `TrapUnreachable` in LLVM which should prevent some cases of
+  undefined behaviour.][45920]


It would be more accurate to say that it mitigates the impact of the UB. This change doesn't make any programs defined that were previously UB, it just makes it more likely they trap at runtime instead of executing arbitrary code.

mark-i-m · 2017-11-28T17:09:31Z

Woah... this is going to be a very large release if those are all release notes from the first week...

steveklabnik · 2017-11-28T17:24:02Z

@mark-i-m no, they're from the previous six-week cycle; remember that we have the train model, so master is 1.24.

cuviper · 2017-11-28T17:45:36Z

RELEASES.md

+Libraries
+---------
+- [impl `From<T>` for `Mutex<T>` and `RwLock<T>`][46082]
+- [Allow a trailling comma in `assert_eq/ne` macro][45887]


cuviper · 2017-11-28T17:48:38Z

RELEASES.md

+  for `AtomicU8`.
+- [Removed the `T: Sync` requirement for `RwLock<T>: Send`][45267]
+- [Removed `T: Sized` requirement for `<*const T>::as_ref`
+  and `<*const T>::as_mut`][44932]


This should be <*const T>::as_ref, <*mut T>::as_ref, and <*mut T>::as_mut.
(and not <*const T>::as_mut)

petrochenkov · 2017-11-28T18:43:08Z

RELEASES.md

+
+Language
+--------
+- [Fixed displaying duplicate errors on some trait bounds.][45772]


#45772 is a language change - arbitrary auto traits are permitted in trait objects, but not displaying duplicate errors is not a language change.

petrochenkov · 2017-11-28T18:44:26Z

RELEASES.md

+- [rustc now suggests renaming import if names clash.][45660]
+- [Display errors/warnings correctly when there are zero-width or
+  wide characters.][45711]
+- [rustc now uses subtyping on the left hand side of binary operations.][45435]


This is kind of language change.

ollie27

#44042 and #45682 are also missing.

ollie27 · 2017-11-29T16:09:13Z

RELEASES.md

+- [Implement Hash for raw pointers to unsized types][45483]
+- [impl `From<*mut T>` for `AtomicPtr<T>`][45610]
+- [impl `From<{number_size}>` for `Atomic{number_size}`][45610] eg. `From<u8>`
+  for `AtomicU8`.


AtomicU8 isn't stable. This should only mention AtomicUsize and AtomicIsize.

ollie27 · 2017-11-29T16:10:29Z

RELEASES.md

+
+Compatibility Notes
+-------------------
+- [`fmt::Arguments` can no longer be shared across threads.][45198]


This didn't make it into 1.23.0.

ollie27 · 2017-11-29T16:11:14Z

RELEASES.md

+
+Libraries
+---------
+- [impl `From<T>` for `Mutex<T>` and `RwLock<T>`][46082]


This didn't make it into 1.23.0.

ollie27 · 2017-11-29T16:11:33Z

RELEASES.md

+- [Optimized `Thread::{park, unpark}` implementation][45524]
+- [Improved `SliceExt::binary_search` performance.][45333]
+- [Optimized `Read::read_to_end`.][46050] This increase file read speed and for
+  small files reduce the number of syscalls.


This didn't make it into 1.23.0.

ollie27 · 2017-11-29T16:12:59Z

RELEASES.md

+  in rare cases this could break some code.][45853] [Tracking issue for
+  further information][45852]
+- [Changed how closures are stored, as a result of this change you can no longer
+  have a situation where a closure directly calls itself.][45879]


This didn't make it into 1.23.0.

ollie27 · 2017-11-29T16:29:05Z

RELEASES.md

+  small files reduce the number of syscalls.
+
+Stabilized APIs
+---------------


#45990 didn't make it into 1.23.0.

alexcrichton · 2017-12-08T19:48:04Z

Oh one important thing to call out maybe is that we're turning on 16 codegen units by default in debug builds, which should bring some nice parallellism wins to debug builds! (aka faster debug builds)

kennytm · 2017-12-21T21:31:49Z

RELEASES.md

+- [rustc now avoids unnecessary copies of arguments that are
+  simple bindings][45380] This should improve memory usage on average by 5-10%.
+- [Updated musl used to build musl rustc to 1.1.17][45393]
+- [Refactored type memory layouts and ABIs.][45225] This will reduce


If #46925 is merged, please remove this item.

alexcrichton · 2017-12-29T16:48:58Z

With the release going out soon, let's merge!

@bors: r+

bors · 2017-12-29T16:48:59Z

📌 Commit a1438b7 has been approved by alexcrichton

XAMPPRocky · 2017-12-29T16:51:31Z

@alexcrichton I haven't added the note about 16 codegen units, I can't seem to find the PR that merges that in?

bors · 2017-12-29T16:51:45Z

⌛ Testing commit a1438b7 with merge 19c656bf224f689401437b0e3ce7dd2da8d3abb6...

alexcrichton · 2017-12-29T17:00:41Z

Oh heh looks like that happened in #44853 and was reduced to 16 in #45064, and turns out that's in 1.22!

bors · 2017-12-29T17:32:13Z

💔 Test failed - status-travis

kennytm · 2017-12-29T17:38:48Z

@bors retry #40474

[00:06:08]  Downloading rand v0.3.18
[00:06:09]  Downloading regex v0.2.3

No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

Updated RELEASES.md for 1.23.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

bors · 2017-12-29T20:23:12Z

⌛ Testing commit a1438b7 with merge 2dad872...

bors · 2017-12-29T23:07:38Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 2dad872 to master...

Updated RELEASES.md for 1.23.0

3dffaa0

rust-highfive assigned nikomatsakis Nov 28, 2017

kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 28, 2017

steveklabnik reviewed Nov 28, 2017

View reviewed changes

kennytm reviewed Nov 28, 2017

View reviewed changes

hanna-kruppe reviewed Nov 28, 2017

View reviewed changes

cuviper reviewed Nov 28, 2017

View reviewed changes

petrochenkov reviewed Nov 28, 2017

View reviewed changes

ollie27 reviewed Nov 29, 2017

View reviewed changes

Update RELEASES.md

b5b3da3

kennytm reviewed Dec 21, 2017

View reviewed changes

Update RELEASES.md

a1438b7

kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2017

bors added a commit that referenced this pull request Dec 29, 2017

Auto merge of #46327 - Aaronepower:master, r=alexcrichton

2dad872

Updated RELEASES.md for 1.23.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md)

bors merged commit a1438b7 into rust-lang:master Dec 29, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated RELEASES.md for 1.23.0 #46327

Updated RELEASES.md for 1.23.0 #46327

XAMPPRocky commented Nov 28, 2017

rust-highfive commented Nov 28, 2017

steveklabnik Nov 28, 2017

kennytm Nov 28, 2017 •

edited

Loading

ollie27 Nov 29, 2017

kennytm Nov 29, 2017

kennytm Nov 28, 2017

kennytm Nov 28, 2017 •

edited

Loading

hanna-kruppe Nov 28, 2017

mark-i-m commented Nov 28, 2017

steveklabnik commented Nov 28, 2017

cuviper Nov 28, 2017

cuviper Nov 28, 2017

petrochenkov Nov 28, 2017

petrochenkov Nov 28, 2017

ollie27 left a comment

ollie27 Nov 29, 2017

ollie27 Nov 29, 2017

ollie27 Nov 29, 2017

ollie27 Nov 29, 2017

ollie27 Nov 29, 2017

ollie27 Nov 29, 2017

alexcrichton commented Dec 8, 2017

kennytm Dec 21, 2017

alexcrichton commented Dec 29, 2017

bors commented Dec 29, 2017

XAMPPRocky commented Dec 29, 2017

bors commented Dec 29, 2017

alexcrichton commented Dec 29, 2017

bors commented Dec 29, 2017

kennytm commented Dec 29, 2017

bors commented Dec 29, 2017

bors commented Dec 29, 2017

Updated RELEASES.md for 1.23.0 #46327

Updated RELEASES.md for 1.23.0 #46327

Conversation

XAMPPRocky commented Nov 28, 2017

rust-highfive commented Nov 28, 2017

Choose a reason for hiding this comment

kennytm Nov 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kennytm Nov 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mark-i-m commented Nov 28, 2017

steveklabnik commented Nov 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ollie27 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexcrichton commented Dec 8, 2017

Choose a reason for hiding this comment

alexcrichton commented Dec 29, 2017

bors commented Dec 29, 2017

XAMPPRocky commented Dec 29, 2017

bors commented Dec 29, 2017

alexcrichton commented Dec 29, 2017

bors commented Dec 29, 2017

kennytm commented Dec 29, 2017

bors commented Dec 29, 2017

bors commented Dec 29, 2017

kennytm Nov 28, 2017 •

edited

Loading

kennytm Nov 28, 2017 •

edited

Loading