Use name-discarding LLVM context #47220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only applicable when neither of --emit=llvm-ir or --emit=llvm-bc are not requested. In case either of these outputs are wanted, but the benefits of such context are desired as well, -Zfewer_names option provides the same functionality regardless of the outputs requested.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @eddyb or @nikomatsakis |
|
Some sort of test would be nice, but the only variant that can reasonably be tested is @bors r+ |
|
📌 Commit b719578 has been approved by |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit b719578 has been approved by |
eddyb
reviewed
Jan 5, 2018
| free((void *)LastError); | ||
| LastError = strdup(Err); | ||
| } | ||
|
|
||
| extern "C" LLVMContextRef LLVMRustContextCreate(bool shouldDiscardNames) { | ||
| auto ctx = new LLVMContext(); | ||
| ctx->setDiscardValueNames(shouldDiscardNames); |
There was a problem hiding this comment.
Why not expose just that method? Seems self-documenting.
There was a problem hiding this comment.
Just an arbitrary decision. I feel that function with an argument is slightly cleaner for our use-case.
eddyb
added
the
beta-nominated
shepmaster
added
the
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 6, 2018
Use name-discarding LLVM context This is only applicable when neither of --emit=llvm-ir or --emit=llvm-bc are not requested. In case either of these outputs are wanted, but the benefits of such context are desired as well, -Zfewer_names option provides the same functionality regardless of the outputs requested. Should be a viable fix for rust-lang#46449
bors
added a commit
that referenced
this pull request
Jan 6, 2018
nagisa
added
the
T-compiler
nikomatsakis
added
the
beta-accepted
|
I'll prepare a backport of this soon. |
alexcrichton
removed
the
beta-nominated
|
Seems like @alexcrichton beat me to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only applicable when neither of --emit=llvm-ir or --emit=llvm-bc are not
requested.
In case either of these outputs are wanted, but the benefits of such context are
desired as well, -Zfewer_names option provides the same functionality regardless
of the outputs requested.
Should be a viable fix for #46449