Enforce dashes in the unstable book file names #47414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
added
the
S-waiting-on-review
|
Looks like there's some compilation failures: https://travis-ci.org/rust-lang/rust/builds/328459014#L1396. |
Also rename the existing underscore using files to use dashes. Fixes rust-lang#47394.
|
@bors: r+ |
|
📌 Commit 38e2667 has been approved by |
estebank
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 15, 2018
Enforce dashes in the unstable book file names Also rename the existing underscore using files to use dashes. Fixes rust-lang#47394.
est31
added a commit
to est31/rust
that referenced
this pull request
Jan 15, 2018
Previously, any deadlinks from a book's SUMMARY.md wouldn't cause any errors or warnings or similar but mdbook would simply create a page with blank content. This has kept bug rust-lang#47394 hidden. It should have been detected back in the PR when those wrongly named files got added to the book. PR rust-lang#47414 was one component of the solution. This change is a second line of defense for the unstable book and a first line of defense for any other book. We also update mdbook to the most recent version.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Jan 23, 2018
…hton Check for deadlinks from the summary during book generation Previously, any deadlinks from a book's SUMMARY.md wouldn't cause any errors or warnings or similar but mdbook would simply create a page with blank content. This has kept bug rust-lang#47394 hidden. It should have been detected back in the PR when those wrongly named files got added to the book. PR rust-lang#47414 was one component of the solution. This change is a second line of defense for the unstable book and a first line of defense for any other book. We also update mdbook to the most recent version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename the existing underscore using files to use dashes.
Fixes #47394.