Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for intra-doc-links #47701

Merged
merged 7 commits into from
Jan 26, 2018
Merged

Fixes for intra-doc-links #47701

merged 7 commits into from
Jan 26, 2018

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Jan 24, 2018 •
edited
Loading

Turn errors into warnings, also handle methods, trait items, and variants.

r? @killercup @QuietMisdreavus

@Manishearth Manishearth mentioned this pull request Jan 24, 2018
Closed
27 tasks
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 24, 2018
@Manishearth Manishearth changed the title Turn intra-doc-links error into warning Fixes for intra-doc-links Jan 24, 2018
@QuietMisdreavus
Copy link
Member

I'm not all too familiar with how the resolution stuff works, but it seems pretty sound to me. Can you extend the src/test/rustdoc/intra-links.rs to make sure this works as expected?

@Manishearth
Copy link
Member Author

Added tests

@QuietMisdreavus
Copy link
Member

Thanks so much! This will get a major checkbox out of the way on #43466.

@bors r+

@bors
Copy link
Contributor

bors commented Jan 25, 2018

📌 Commit 08ca4fd has been approved by QuietMisdreavus

@alexcrichton alexcrichton mentioned this pull request Jan 25, 2018
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 25, 2018
@alexcrichton
Rollup merge of rust-lang#47701 - Manishearth:intra-fixes, r=QuietMis…
b335b10 
…dreavus

Fixes for intra-doc-links

Turn errors into warnings, also handle methods, trait items, and variants.

r? @killercup @QuietMisdreavus
bors added a commit that referenced this pull request Jan 26, 2018
@bors
Auto merge of #47748 - alexcrichton:rollup, r=alexcrichton
bacb5c5 
Rollup of 19 pull requests

- Successful merges: #47415, #47437, #47439, #47453, #47460, #47502, #47529, #47600, #47607, #47618, #47626, #47656, #47668, #47696, #47701, #47705, #47710, #47711, #47719
- Failed merges: #47455, #47521
@bors bors merged commit 08ca4fd into rust-lang:master Jan 26, 2018
@Manishearth Manishearth deleted the intra-fixes branch February 6, 2018 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Manishearth @QuietMisdreavus @bors @kennytm