-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the "leak check" in favor of "universes" #48407
Commits on Mar 14, 2018
-
Revert "change skolemizations to use universe index"
This reverts commit 755bdaa.
Configuration menu - View commit details
-
Copy full SHA for 48df576 - Browse repository at this point
Copy the full SHA 48df576View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50bd71c - Browse repository at this point
Copy the full SHA 50bd71cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dad682 - Browse repository at this point
Copy the full SHA 5dad682View commit details -
Revert "change skolemizations to use universe index"
This reverts commit 35e78b5.
Configuration menu - View commit details
-
Copy full SHA for 2a94f30 - Browse repository at this point
Copy the full SHA 2a94f30View commit details -
Revert "introduce
UniverseIndex
intoParamEnv
"This reverts commit d4df52c.
Configuration menu - View commit details
-
Copy full SHA for f6e6d23 - Browse repository at this point
Copy the full SHA f6e6d23View commit details -
Revert "add universes to type inference variables"
This reverts commit 13efaf0.
Configuration menu - View commit details
-
Copy full SHA for 26d1fc7 - Browse repository at this point
Copy the full SHA 26d1fc7View commit details -
introduce
UniverseIndex
intoInferCtxt
Always using root environment for now.
Configuration menu - View commit details
-
Copy full SHA for 3d4791b - Browse repository at this point
Copy the full SHA 3d4791bView commit details -
add universes to type inference variables
This gives each type inference variable a notion of universe but doesn't do anything with it. We can always get the "current universe" from infer_ctxt. This relies on the property of type variables that they can never interact with siblings.
Configuration menu - View commit details
-
Copy full SHA for ff17bd7 - Browse repository at this point
Copy the full SHA ff17bd7View commit details -
change skolemizations to use universe index
This is sort of confusing "side step". All it does is to change the representation of a skolemized region. but the source of that universe index is not the inference context, which is what we eventually want, but rather an internal counter in the region inference context. We'll patch that up later. But doing this now ought to help with confusing diffs later.
Configuration menu - View commit details
-
Copy full SHA for 66520ff - Browse repository at this point
Copy the full SHA 66520ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 534d5d1 - Browse repository at this point
Copy the full SHA 534d5d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59f3b20 - Browse repository at this point
Copy the full SHA 59f3b20View commit details -
make solving "universe aware", in a simplistic way
This simple change says that if you have a constraint like ``` exists<'a> { for<'b> { 'a: 'b } } ``` you can solve it by making 'a static. This is "good enough" for now, though not super smart, since for example ``` exists<'a> { for<'b> { if ('a: 'b) { 'a: 'b } } } ``` will still force 'a to be 'static, though it should not. (We don't intend to fix that in this PR series; current rustc kind of sidesteps the need to consider such concerns at the moment.)
Configuration menu - View commit details
-
Copy full SHA for ad9e9d9 - Browse repository at this point
Copy the full SHA ad9e9d9View commit details -
kill higher_ranked_lub and higher_ranked_glb
These are only used to provide a better hint for code that was phased out long ago. We can just remove it. It's been long enough.
Configuration menu - View commit details
-
Copy full SHA for 24478c4 - Browse repository at this point
Copy the full SHA 24478c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 367be87 - Browse repository at this point
Copy the full SHA 367be87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aca3b9 - Browse repository at this point
Copy the full SHA 5aca3b9View commit details -
Wrap
InferCtxt::universe
in a cellWe'll need this in order to start tracking skolemizatoins here, and it's easier to update all the field accesses now rather than later.
Configuration menu - View commit details
-
Copy full SHA for afb4010 - Browse repository at this point
Copy the full SHA afb4010View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b8008f - Browse repository at this point
Copy the full SHA 3b8008fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bc324a - Browse repository at this point
Copy the full SHA 0bc324aView commit details -
remove all failing tests so we can do a crater run
Configuration menu - View commit details
-
Copy full SHA for 17e0577 - Browse repository at this point
Copy the full SHA 17e0577View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd90fb5 - Browse repository at this point
Copy the full SHA bd90fb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 725eeb0 - Browse repository at this point
Copy the full SHA 725eeb0View commit details
Commits on Mar 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 3f599ad - Browse repository at this point
Copy the full SHA 3f599adView commit details