Support parentheses in patterns under feature gate #48500
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @rust-lang/lang |
|
Also related to #48501 |
kennytm
added
the
T-lang
|
☔ The latest upstream changes (presumably #48520) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
petrochenkov
added
S-waiting-on-review
|
Indeed, I see no reason not to permit |
src/libsyntax/parse/parser.rs
Outdated
| -> PResult<'a, (Vec<P<Pat>>, Option<usize>)> { | ||
| let mut fields = vec![]; | ||
| let mut ddpos = None; | ||
| fn parse_pat_tuple(&mut self) -> PResult<'a, (Vec<P<Pat>>, Option<usize>, bool)> { |
There was a problem hiding this comment.
Nit: I'd prefer a name like parse_pat_parenthesized_list. Also, a comment explaining this would be nice. Something like:
Parses a parenthesized list of patterns like (), (p), (p,), (p, q), or (p, q, ..). Returns a vector of the subpatterns that were parsed, along with (a) an option indicating the index of the .. element and (b) a boolean indicating whether a trailing comma was present. Trailing commas are significant because (p) and (p,) are different patterns.
Improve recovery for trailing comma after `..`
|
@bors r=nikomatsakis |
|
📌 Commit c9aff92 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 200, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Support parentheses in patterns under feature gate This is a prerequisite for any other extensions to pattern syntax - `|` with multiple patterns, type ascription, `..PAT` in slice patterns. Closes rust-lang/rfcs#554
This is a prerequisite for any other extensions to pattern syntax -
|with multiple patterns, type ascription,..PATin slice patterns.Closes rust-lang/rfcs#554