Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Great Generics Generalisation: Ty Edition #48523

Merged
merged 40 commits into from
May 16, 2018
Merged

The Great Generics Generalisation: Ty Edition #48523

merged 40 commits into from
May 16, 2018

Commits on May 15, 2018

  1. Consolidate ty::Generics

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    fe0c119 View commit details
    Browse the repository at this point in the history

  2. Reduce parent_params to parent_count

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    de1c29c View commit details
    Browse the repository at this point in the history

  3. Rename ty::Generics::parameters to params

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    6355354 View commit details
    Browse the repository at this point in the history

  4. Rename ty::GenericParameterDef to GenericParam

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    e9e3d57 View commit details
    Browse the repository at this point in the history

  5. Prefer iterator to vec

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    e5825c2 View commit details
    Browse the repository at this point in the history

  6. Inline Generics::own_count

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    5b4e2b7 View commit details
    Browse the repository at this point in the history

  7. Fix generics type parameter handling in miri

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    a9622dc View commit details
    Browse the repository at this point in the history

  8. Rename has_type_parameters to requires_monomorphization

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    15d2759 View commit details
    Browse the repository at this point in the history

  9. Rename GenericParam to GenericParamDef

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    178a8f1 View commit details
    Browse the repository at this point in the history

  10. Rename TypeParameterDef -> TypeParamDef and RegionParameterDef -> Reg… 

    …ionParamDef
    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    06f0a7c View commit details
    Browse the repository at this point in the history

  11. Fix tidy errors caused by renaming

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    cadf96e View commit details
    Browse the repository at this point in the history

  12. Generalise cases of explicit iteration of specific kinds

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    4a6c946 View commit details
    Browse the repository at this point in the history

  13. Generalise more cases of explicit iteration of specific kinds

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    b75f421 View commit details
    Browse the repository at this point in the history

  14. Eliminate ty::Generics::lifetimes() 

    Begone lazy lifetime code!
    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    d557ff9 View commit details
    Browse the repository at this point in the history

  15. Eliminate ty::Generics::types() 

    And with one final incanation, the specific kind iterators were banished from ty::Generics, never to be seen again!
    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    0b8b14f View commit details
    Browse the repository at this point in the history

  16. Correct variable renaming fallout

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    6f257bf View commit details
    Browse the repository at this point in the history

  17. Place Self at the start of ty::Generics' param lists

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    a17896a View commit details
    Browse the repository at this point in the history

  18. Use GenericParamCount instead of FxHashMap

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    7b45a89 View commit details
    Browse the repository at this point in the history

  19. Replace type_param_to_index with param_def_id_to_index

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    df1c256 View commit details
    Browse the repository at this point in the history

  20. Refactor to address comments

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    d62fc23 View commit details
    Browse the repository at this point in the history

  21. Fix typo in late-bound region testing message

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    fc27c2e View commit details
    Browse the repository at this point in the history

  22. Inline get_type

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    5e89312 View commit details
    Browse the repository at this point in the history

  23. Pull common parameters into GenericParamDef 

    This leads to a lot of simplifications, as most code doesn't actually need to know about the specific lifetime/type data; rather, it's concerned with properties like name, index and def_id.
    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    4bed895 View commit details
    Browse the repository at this point in the history

  24. Rename RegionParamDef to LifetimeParamDef

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    9f9d4be View commit details
    Browse the repository at this point in the history

  25. Fix rebase fallout

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    18f77e2 View commit details
    Browse the repository at this point in the history

  26. Refactor generic params loops

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    9200bde View commit details
    Browse the repository at this point in the history

  27. Lift pure_wrt_drop to GenericParamDef

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    007de2f View commit details
    Browse the repository at this point in the history

  28. Remove GenericParamDef::to_type

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    365c8c3 View commit details
    Browse the repository at this point in the history

  29. Rename param_counts to own_counts

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    fd8e284 View commit details
    Browse the repository at this point in the history

  30. Review refactoring

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    fe1f651 View commit details
    Browse the repository at this point in the history

  31. Refactoring generic counting loops

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    b575c18 View commit details
    Browse the repository at this point in the history

  32. Update bad-annotation error message

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    25bf73d View commit details
    Browse the repository at this point in the history

  33. Clean up generic param handling

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    030f10f View commit details
    Browse the repository at this point in the history

  34. Refactor Substs methods on generic parameters

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    d9190da View commit details
    Browse the repository at this point in the history

  35. Clean up shared subst code

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    3ae2468 View commit details
    Browse the repository at this point in the history

  36. Use Kind instead of UnpackedKind in Substs methods

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    e9c28b2 View commit details
    Browse the repository at this point in the history

  37. Add mk_param_from_def

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    0a9371a View commit details
    Browse the repository at this point in the history

  38. Clean up dropck_outlives PhantomData handling

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    39a68e9 View commit details
    Browse the repository at this point in the history

  39. Collapse Substs::identity_for_item in collect

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    5ea91ac View commit details
    Browse the repository at this point in the history

  40. One must always remember to clean up after themselves

    @varkor
    varkor committed May 15, 2018
    Configuration menu
    Copy the full SHA
    5be2bdb View commit details
    Browse the repository at this point in the history