Restore the download of rust-mingw #48637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
kennytm
reviewed
Mar 1, 2018
src/bootstrap/bootstrap.py
Outdated
| @@ -350,6 +350,11 @@ def download_stage0(self): | |||
| self.fix_executable("{}/bin/rustdoc".format(self.bin_root())) | |||
| with open(self.rustc_stamp(), 'w') as rust_stamp: | |||
| rust_stamp.write(self.date) | |||
|
|
|||
There was a problem hiding this comment.
[00:05:29] tidy error: /checkout/src/bootstrap/bootstrap.py:353: trailing whitespace
The build might otherwise break due to mixing MinGW object files from rust-std and the local MinGW which might be newer/older than the version used to build rust-std. Fixes rust-lang#48272
segevfiner
force-pushed
the
restore-rust-mingw-download
branch
from
f6c9c9b
to
39d0b05
Compare
|
Thanks! Could you leave a comment as to why this is happening as well? |
|
@bors: r+ |
|
📌 Commit 5332d9a has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 2, 2018
…oad, r=alexcrichton Fixes rust-lang#47311. r? @nrc
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 3, 2018
…oad, r=alexcrichton Restore the download of rust-mingw The build might otherwise break due to mixing MinGW object files from rust-std and the local MinGW which might be newer/older than the version used to build rust-std. Fixes rust-lang#48272 r? @alexcrichton
bors
added a commit
that referenced
this pull request
Mar 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build might otherwise break due to mixing MinGW object files from rust-std and the local MinGW which might be newer/older than the version used to build rust-std.
Fixes #48272
r? @alexcrichton