Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump racer and home #49203

Merged
merged 1 commit into from
Mar 24, 2018
Merged

Bump racer and home #49203

merged 1 commit into from
Mar 24, 2018

Conversation

Eijebong
Copy link
Contributor

This removes 10 dependencies from the build 🎉

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 20, 2018
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1 conflicts/speedup

@bors
Copy link
Contributor

bors commented Mar 20, 2018

📌 Commit 8a42304 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2018
@bors
Copy link
Contributor

bors commented Mar 20, 2018

☔ The latest upstream changes (presumably #49190) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2018
@Eijebong
Copy link
Contributor Author

Rebased

@kennytm
Copy link
Member

kennytm commented Mar 20, 2018

@bors r=Mark-Simulacrum

Unfortunately I guess you'll need to prepare for another rebase because many PRs are also changing Cargo.lock 😥

@bors
Copy link
Contributor

bors commented Mar 20, 2018

📌 Commit ffb3d09 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2018
@Eijebong
Copy link
Contributor Author

I don't even rebase, I just reset to master and rerun the update command :p It's pretty easy.

@bors
Copy link
Contributor

bors commented Mar 21, 2018

☔ The latest upstream changes (presumably #49221) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 21, 2018
@Eijebong
Copy link
Contributor Author

rebased

@alexcrichton
Copy link
Member

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Mar 21, 2018

📌 Commit 0816ed1 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 21, 2018
@bors
Copy link
Contributor

bors commented Mar 21, 2018

⌛ Testing commit 0816ed16abce408b9900318f3971520802bbd969 with merge 4c56fefaecd807cb6ab3de050bcecb8dec7de9ba...

@bors
Copy link
Contributor

bors commented Mar 21, 2018

💔 Test failed - status-travis

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 21, 2018
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 22, 2018
@Eijebong
Copy link
Contributor Author

Build execution time has reached the maximum allowed time for your plan (180 minutes).

@pietroalbini
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2018
@bors
Copy link
Contributor

bors commented Mar 23, 2018

⌛ Testing commit 06f8103 with merge 40b4f353c67ad954bcfcba1b2d4b29419f0e0343...

@alexcrichton
Copy link
Member

@bors: retry p=0 rollup

I pushed to master so this'd need to get retested, I don't think this needs to be high priority as we've got a ton of other fixes in the queue. This passed almost all tests to switching to rollup priority

@alexcrichton alexcrichton mentioned this pull request Mar 23, 2018
Merged
bors added a commit that referenced this pull request Mar 23, 2018
@bors
Auto merge of #49308 - alexcrichton:rollup, r=alexcrichton
c08480f 
Rollup of 15 pull requests

- Successful merges: #48265, #48528, #48552, #48624, #48883, #48909, #49028, #49030, #49102, #49160, #49169, #49203, #49262, #49272, #49295
- Failed merges: #48942, #49035
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 23, 2018
@alexcrichton
Rollup merge of rust-lang#49203 - Eijebong:lets-cleanup-dependencies,…
7fbc373 
… r=Mark-Simulacrum

Bump racer and home

This removes 10 dependencies from the build 🎉
@alexcrichton alexcrichton mentioned this pull request Mar 23, 2018
Closed
@kennytm kennytm mentioned this pull request Mar 24, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
@kennytm
Rollup merge of rust-lang#49203 - Eijebong:lets-cleanup-dependencies,…
f34d4f6 
… r=Mark-Simulacrum

Bump racer and home

This removes 10 dependencies from the build 🎉
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2018
@kennytm
Rollup merge of rust-lang#49203 - Eijebong:lets-cleanup-dependencies,…
2bd27c9 
… r=Mark-Simulacrum

Bump racer and home

This removes 10 dependencies from the build 🎉
@kennytm kennytm mentioned this pull request Mar 24, 2018
Merged
bors added a commit that referenced this pull request Mar 24, 2018
@bors
Auto merge of #49337 - kennytm:rollup, r=kennytm
f5631d9 
Rollup of 21 pull requests

- Successful merges: #49046, #49076, #49089, #49120, #49121, #49122, #49162, #49193, #49194, #49203, #49229, #49235, #49254, #49268, #49273, #49274, #49290, #49312, #49314, #49318, #49299
@bors bors merged commit 06f8103 into rust-lang:master Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Eijebong @rust-highfive @Mark-Simulacrum @bors @kennytm @alexcrichton @pietroalbini